Add path erroneously removed from CODEOWNERS
#28539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konrad-jamrozik
added
the
Central-EngSys
konrad-jamrozik
requested review from
jsquire and
ronniegeraghty
as code owners
konrad-jamrozik
changed the title
CODEOWNERS.CODEOWNERS
benbp
approved these changes
Jan 31, 2023
weshaggard
reviewed
Feb 1, 2023
konrad-jamrozik
commented
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced by:
I.e. by converting path
/sdk/ml/azure-ai-ml/azure/ai/ml/_schema/jobinto
/sdk/ml/azure-ai-ml/azure/ai/ml/_schema/job/I made it stop matching [1] against
sdk/ml/azure-ai-ml/azure/ai/ml/_schema/job_resource_configuration.pyThis fixes it.
[1] Strictly speaking the path may have not been matching in the first place, per .gitignore doc and
CODEOWNERSdoc. However, it seems to me what this PR proposes is in fact the intended behavior.