Resolve black not running properly in CI
#28756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
added
the
Central-EngSys
benbp
reviewed
Feb 14, 2023
benbp
approved these changes
Feb 14, 2023
Co-authored-by: Ben Broderick Phillips <[email protected]>
Member
Author
|
Holding off on merging this until tomorrow. @kdestin FYI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #28742
@mccoyp @kristapratico @lmazuel for awareness.
Thank you @kdestin for noticing and reaching out! I don't know that I would have seen this, as all my local verifications were just
pip install black-ing and invokingvalidate_formatting.py.....which obviously worked just fine, as this issue isn't present on latestblack.PR Unblocking this one: #28782