Skip to content

Resolve black not running properly in CI #28756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scbedd merged 5 commits into from
Feb 15, 2023
Merged

Resolve black not running properly in CI #28756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1952496
resolve black not running properly
scbedd Feb 11, 2023
c1b17e8
ensure that output still happens in the success case
scbedd Feb 13, 2023
244f1b0
ensure variable names in azure-core/tests/test_serialization.py are a…
scbedd Feb 13, 2023
34468aa
Update scripts/devops_tasks/validate_formatting.py
scbedd Feb 14, 2023
9c88598
Merge remote-tracking branch 'upstream/main' into resolve_skipped_black
scbedd Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/pipelines/templates/steps/run_black.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ steps:
condition: succeededOrFailed()

- script: |
pip install black==21.6b0 tools/azure-sdk-tools["build"]
pip install black==22.3.0 tools/azure-sdk-tools["build"]
displayName: 'Prep Environment'
condition: succeededOrFailed()

Expand Down
13 changes: 9 additions & 4 deletions scripts/devops_tasks/validate_formatting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,15 @@ def run_black(service_dir):

if stderr:
results.append((package_name, stderr))

if stdout:
if "reformatted" in stdout.decode('utf-8'):
results.append((package_name, False))

if out.returncode > 0:
print(f"black ran into an unexpected failure while analyzing the code for {package_name}")
if stdout:
print(stdout.decode('utf-8'))
exit(out.returncode)

if stdout and "reformatted" in stdout.decode('utf-8'):
results.append((package_name, False))
else:
print(f"black succeeded against {package_name}")

Expand Down