Skip to content

Conversation

@kdestin
Copy link
Member

@kdestin kdestin commented Feb 15, 2023

Description

This PR:

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to approve this, but let me get sign off from one of the python devs as well ok @kdestin ?

@kdestin
Copy link
Member Author

kdestin commented Feb 15, 2023

I am going to approve this, but let me get sign off from one of the python devs as well ok @kdestin ?

Works for me

@kdestin kdestin mentioned this pull request Feb 15, 2023
6 tasks
@scbedd scbedd merged commit 4a36d56 into Azure:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants