Skip to content

[tooling] Add exclusions to black for auto generated code #28835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scbedd merged 3 commits into from
Feb 15, 2023
Merged

[tooling] Add exclusions to black for auto generated code #28835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9485064
Add exclusions to black for auto generated code
kdestin Feb 15, 2023
54184de
Only exclude restclient by default for now
kdestin Feb 15, 2023
2b42d02
Exclude _restclient only for azure-ai-ml
kdestin Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions eng/black-pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
[tool.black]
line-length = 120
extend-exclude = '''
# Exclude some directories from formatting (note the slashes surrounding the pattern)
/(
azure/ai/ml/_restclient
)/
'''
2 changes: 1 addition & 1 deletion scripts/devops_tasks/validate_formatting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def run_black(service_dir):
package_name = os.path.basename(package)

if is_check_enabled(package, "black", True):
out = subprocess.Popen([sys.executable, "-m", "black", "-l", "120", "sdk/{}/{}".format(service_dir, package_name)],
out = subprocess.Popen([sys.executable, "-m", "black", "--config", os.path.join(root_dir, "eng", "black-pyproject.toml"), os.path.join("sdk", service_dir, package_name)],
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
cwd = root_dir
Expand Down