[Core] Add anyio dependency for lock handling#33307
Merged
pvaneck merged 2 commits intoAzure:mainfrom Nov 30, 2023
Merged
Conversation
pvaneck
force-pushed
the
anyio
branch
2 times, most recently
from
6400320 to
c2b637c
Compare
Collaborator
|
API change check API changes are not detected in this pull request. |
- This introduces anyio as a dependency to azure-core and we leverage its `Lock` class in `AsyncBearerTokenCredentialPolicy` to allow it to work with both asyncio and trio concurrency mechanisms. - Requests was also bumped to allow the mindependency check to pass with the minimum version of `anyio`. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
requested review from
annatisch,
iscai-msft,
johanste,
kashifkhan,
lmazuel,
tjprescott and
xiangyan99
as code owners
johanste
reviewed
Nov 28, 2023
lmazuel
reviewed
Nov 28, 2023
lmazuel
approved these changes
Nov 28, 2023
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Member
Author
|
/check-enforcer override |
Contributor
|
😩 This forces installation of multiple additional transitive dependencies for any and all users of It might be better to explore whether the same thing could be done without forcing the dependency; after all, there are plenty of other places in |
6 tasks
Member
Thanks for your feedback. In terms of "there are plenty of other places in azure-core that only support asyncio still." if you don't mind, could you share more details? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
anyioas a dependency toazure-core, and we leverage itsLockclass inAsyncBearerTokenCredentialPolicyto allow it to work with both asyncio and trio concurrency mechanisms.requestswas also bumped to allow themindependencycheck to pass with the minimum version ofanyio.Closes: #32968