address paul's comments

sdk/core/corehttp/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Release History
 
+## 1.0.0b3 (2024-02-01)
+
+### Breaking Changes
+
+- The `SansIOHTTPPolicy` and `HTTPPolicy` under `corehttp.runtime.policies` are now `typing.Protocols`. [#34296](https://github.com/Azure/azure-sdk-for-python/pull/34296)
+
+
 ## 1.0.0b3 (2024-02-01)
 
 ### Features Added

sdk/core/corehttp/corehttp/runtime/pipeline/_base.py

@@ -133,8 +133,8 @@ def __init__(
                 self._impl_policies.append(policy)
             elif isinstance(policy, SansIOHTTPPolicy):
                 self._impl_policies.append(_SansIOHTTPPolicyRunner(policy))
-            elif policy:
-                self._impl_policies.append(policy)
+            else:
+                raise TypeError("Unsupported policy type: {}".format(type(policy)))
         for index in range(len(self._impl_policies) - 1):
             self._impl_policies[index].next = self._impl_policies[index + 1]
         if self._impl_policies:

sdk/core/corehttp/corehttp/runtime/pipeline/_base_async.py

@@ -137,8 +137,8 @@ def __init__(
                 self._impl_policies.append(policy)
             elif isinstance(policy, SansIOHTTPPolicy):
                 self._impl_policies.append(_SansIOAsyncHTTPPolicyRunner(policy))
-            elif policy:
-                self._impl_policies.append(policy)
+            else:
+                raise TypeError("Unsupported policy type: {}".format(type(policy)))
         for index in range(len(self._impl_policies) - 1):
             self._impl_policies[index].next = self._impl_policies[index + 1]
         if self._impl_policies:

sdk/core/corehttp/corehttp/runtime/policies/_base.py

@@ -61,6 +61,7 @@ def send(self, request: PipelineRequest[HTTPRequestType]) -> PipelineResponse[HT
         :return: The pipeline response object.
         :rtype: ~corehttp.runtime.pipeline.PipelineResponse
         """
+        ...
 
 
 @runtime_checkable
@@ -82,6 +83,7 @@ def on_request(self, request: PipelineRequest[SansIOHTTPRequestType_contra]) ->
         :param request: Request to be modified before sent from next policy.
         :type request: ~corehttp.runtime.pipeline.PipelineRequest
         """
+        ...
 
     def on_response(
         self,
@@ -95,6 +97,7 @@ def on_response(
         :param response: Pipeline response object
         :type response: ~corehttp.runtime.pipeline.PipelineResponse
         """
+        ...
 
 
 class RequestHistory(Generic[HTTPRequestType, HTTPResponseType]):

sdk/core/corehttp/corehttp/runtime/policies/_base_async.py

@@ -57,3 +57,4 @@ async def send(
         :return: The pipeline response object.
         :rtype: ~corehttp.runtime.pipeline.PipelineResponse
         """
+        ...