Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix sans io policy tests
  • Loading branch information
swathipil committed Feb 15, 2024
commit 1546e57e4faf8ef94bb967877d8e14a77ea6e0b8
4 changes: 3 additions & 1 deletion sdk/core/corehttp/corehttp/runtime/pipeline/_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,9 @@ def __init__(
self._transport = transport

for policy in policies or []:
if isinstance(policy, SansIOHTTPPolicy):
if hasattr(policy, "send"):
self._impl_policies.append(policy)
elif isinstance(policy, SansIOHTTPPolicy):
self._impl_policies.append(_SansIOHTTPPolicyRunner(policy))
elif policy:
self._impl_policies.append(policy)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,9 @@ def __init__(
self._transport = transport

for policy in policies or []:
if isinstance(policy, SansIOHTTPPolicy):
if hasattr(policy, "send"):
self._impl_policies.append(policy)
elif isinstance(policy, SansIOHTTPPolicy):
self._impl_policies.append(_SansIOAsyncHTTPPolicyRunner(policy))
elif policy:
self._impl_policies.append(policy)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@

@pytest.mark.asyncio
async def test_sans_io_exception():

class SansIOHTTPPolicyImpl(SansIOHTTPPolicy):
def on_request(self, request):
pass
def on_response(self, request, response):
pass

class BrokenSender(AsyncHttpTransport):
async def send(self, request, **config):
raise ValueError("Broken")
Expand All @@ -42,7 +49,7 @@ async def __aexit__(self, exc_type, exc_value, traceback):
"""Raise any exception triggered within the runtime context."""
return self.close()

pipeline = AsyncPipeline(BrokenSender(), [SansIOHTTPPolicy()])
pipeline = AsyncPipeline(BrokenSender(), [SansIOHTTPPolicyImpl()])

req = HttpRequest("GET", "/")
with pytest.raises(ValueError):
Expand Down
9 changes: 8 additions & 1 deletion sdk/core/corehttp/tests/test_pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,13 @@


def test_sans_io_exception():

class SansIOHTTPPolicyImpl(SansIOHTTPPolicy):
def on_request(self, request):
pass
def on_response(self, request, response):
pass

class BrokenSender(HttpTransport):
def send(self, request, **config):
raise ValueError("Broken")
Expand All @@ -45,7 +52,7 @@ def __exit__(self, exc_type, exc_value, traceback):
"""Raise any exception triggered within the runtime context."""
return self.close()

pipeline = Pipeline(BrokenSender(), [SansIOHTTPPolicy()])
pipeline = Pipeline(BrokenSender(), [SansIOHTTPPolicyImpl()])

req = HttpRequest("GET", "/")
with pytest.raises(ValueError):
Expand Down