Skip to content

address API review comments #36058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luigiw merged 20 commits into from
Jun 14, 2024
Merged

address API review comments #36058

Changes from 3 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
9501a12
address comments
Jun 11, 2024
b1ccde0
reintroduce index
Jun 12, 2024
ba75bb8
retrigger checks
Jun 12, 2024
fef5871
lint fixes
MilesHolland Jun 12, 2024
a3c9e1a
retrigger checks
Jun 13, 2024
2585eb5
Merge branch 'adrama/last-minute-api-changes' of https://github.com/A…
Jun 13, 2024
810969c
remove experimental tag
Jun 13, 2024
a14e746
investigating build issues
Jun 13, 2024
35bbba6
revert experimental changes
Jun 13, 2024
2a48be7
make dataclass kw-only
Jun 13, 2024
93720bd
commit docstring
MilesHolland Jun 13, 2024
6092278
Merge branch 'adrama/last-minute-api-changes' of github.com:Adarsh-Ra…
MilesHolland Jun 13, 2024
e873bf8
make index config experimental
MilesHolland Jun 13, 2024
1f0c8ea
remove unused experimental import
MilesHolland Jun 13, 2024
31fd588
correct build_index docstring/typehint
MilesHolland Jun 13, 2024
ceea2d3
kevin's suggestion - remove redundant experimental warning
MilesHolland Jun 13, 2024
79b288a
make all init args keyword only
Jun 13, 2024
31d4cb7
Merge branch 'adrama/last-minute-api-changes' of https://github.com/A…
Jun 13, 2024
f635647
re-order annotations
MilesHolland Jun 13, 2024
c0b2256
run black
MilesHolland Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions sdk/ml/azure-ai-ml/azure/ai/ml/operations/_index_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
)
from azure.ai.ml._telemetry import ActivityType, monitor_with_activity
from azure.ai.ml._utils._asset_utils import _resolve_label_to_asset
from azure.ai.ml._utils._experimental import experimental
from azure.ai.ml._utils._http_utils import HttpPipeline
from azure.ai.ml._utils._logger_utils import OpsLogger
from azure.ai.ml._utils.utils import _get_base_urls_from_discovery_service
Expand Down Expand Up @@ -253,7 +252,6 @@ def cls(rest_indexes: Iterable[RestIndex]) -> List[Index]:
return self._azure_ai_assets.indexes.list(name, list_view_type=list_view_type, cls=cls, **kwargs)

# pylint: disable=too-many-locals
@experimental
def build_index(
self,
*,
Expand All @@ -272,7 +270,7 @@ def build_index(
######## data source info ########
input_source: Union[IndexDataSource, str],
input_source_credential: Optional[Union[ManagedIdentityConfiguration, UserIdentityConfiguration]] = None,
) -> "Job": # type: ignore[name-defined]
) -> Union["Index", "Job"]: # type: ignore[name-defined]
"""Builds an index on the cloud using the Azure AI Resources service.

:keyword name: The name of the index to be created.
Expand All @@ -297,7 +295,7 @@ def build_index(
:paramtype input_source_credential: Optional[Union[~azure.ai.ml.entities.ManagedIdentityConfiguration,
~azure.ai.ml.entities.UserIdentityConfiguration]]
:return: If the `source_input` is a GitSource, returns a created DataIndex Job object.
:rtype: ~azure.ai.ml.entities.Job
:rtype: Union[~azure.ai.ml.entities.Index, ~azure.ai.ml.entities.Job]
:raises ValueError: If the `source_input` is not type ~typing.Str or
~azure.ai.ml.entities._indexes.LocalSource.
"""
Expand Down