-
Notifications
You must be signed in to change notification settings - Fork 3.2k
address API review comments #36058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
luigiw
merged 20 commits into
Azure:main
from
Adarsh-Ramanathan:adrama/last-minute-api-changes
Jun 14, 2024
Merged
address API review comments #36058
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
9501a12
address comments
b1ccde0
reintroduce index
ba75bb8
retrigger checks
fef5871
lint fixes
MilesHolland a3c9e1a
retrigger checks
2585eb5
Merge branch 'adrama/last-minute-api-changes' of https://github.com/A…
810969c
remove experimental tag
a14e746
investigating build issues
35bbba6
revert experimental changes
2a48be7
make dataclass kw-only
93720bd
commit docstring
MilesHolland 6092278
Merge branch 'adrama/last-minute-api-changes' of github.com:Adarsh-Ra…
MilesHolland e873bf8
make index config experimental
MilesHolland 1f0c8ea
remove unused experimental import
MilesHolland 31fd588
correct build_index docstring/typehint
MilesHolland ceea2d3
kevin's suggestion - remove redundant experimental warning
MilesHolland 79b288a
make all init args keyword only
31d4cb7
Merge branch 'adrama/last-minute-api-changes' of https://github.com/A…
f635647
re-order annotations
MilesHolland c0b2256
run black
MilesHolland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
investigating build issues
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.