-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Improvements to mindependency dev_requirement conflict resolution #37669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
87bc0b9
working on a true solution to incompatible requirements on dev_req
scbedd 0338ac9
commit progress, I'm not super happy with the results so far its not …
scbedd b27a374
update from upstream and merge main
scbedd 455d484
commenting the new function
scbedd b1a60b7
we now are recognizing when we have a incompatible dev req, working o…
scbedd a860e46
we've very close now.
scbedd e26e83f
handle incompatible dev requirements
scbedd c1164c9
move new functions to some place that can be more easily tested
scbedd 6c6cc93
ensure we don't accidentally manipulate the standard requirements
scbedd 150b282
add a couple tests
scbedd e5621fa
Update eng/tox/install_depend_packages.py
scbedd a6d75ef
save reformatted functions.py
scbedd c0406bd
repair test in resolve_compatible_package
scbedd 80abb01
Update tools/azure-sdk-tools/ci_tools/functions.py
scbedd 782311c
didn't rename a parametrized argument on a test to match with the def…
scbedd b33a965
fully rename function
scbedd 746036d
handle when there is no specifier in the dev req
scbedd 2e41797
Update eng/tox/install_depend_packages.py
scbedd 3f52835
additionalFilterFn -> additional_filter_fn
scbedd bff0d7d
resolve conflicts and apply black
scbedd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
save reformatted functions.py
- Loading branch information
commit a6d75efccc9b414286ef11f77e6627de6f4a2036
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.