Skip to content

Improvements to mindependency dev_requirement conflict resolution #37669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scbedd merged 20 commits into from
Oct 4, 2024
Merged

Improvements to mindependency dev_requirement conflict resolution #37669

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
87bc0b9
working on a true solution to incompatible requirements on dev_req
scbedd Sep 19, 2024
0338ac9
commit progress, I'm not super happy with the results so far its not …
scbedd Sep 19, 2024
b27a374
update from upstream and merge main
scbedd Sep 30, 2024
455d484
commenting the new function
scbedd Sep 30, 2024
b1a60b7
we now are recognizing when we have a incompatible dev req, working o…
scbedd Oct 1, 2024
a860e46
we've very close now.
scbedd Oct 1, 2024
e26e83f
handle incompatible dev requirements
scbedd Oct 1, 2024
c1164c9
move new functions to some place that can be more easily tested
scbedd Oct 1, 2024
6c6cc93
ensure we don't accidentally manipulate the standard requirements
scbedd Oct 1, 2024
150b282
add a couple tests
scbedd Oct 2, 2024
e5621fa
Update eng/tox/install_depend_packages.py
scbedd Oct 2, 2024
a6d75ef
save reformatted functions.py
scbedd Oct 2, 2024
c0406bd
repair test in resolve_compatible_package
scbedd Oct 2, 2024
80abb01
Update tools/azure-sdk-tools/ci_tools/functions.py
scbedd Oct 2, 2024
782311c
didn't rename a parametrized argument on a test to match with the def…
scbedd Oct 3, 2024
b33a965
fully rename function
scbedd Oct 3, 2024
746036d
handle when there is no specifier in the dev req
scbedd Oct 3, 2024
2e41797
Update eng/tox/install_depend_packages.py
scbedd Oct 3, 2024
3f52835
additionalFilterFn -> additional_filter_fn
scbedd Oct 3, 2024
bff0d7d
resolve conflicts and apply black
scbedd Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fully rename function
  • Loading branch information
@scbedd
scbedd committed Oct 3, 2024
commit b33a965c34d4a07e265bcb19497037c04089292b
4 changes: 2 additions & 2 deletions eng/tox/install_depend_packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,12 @@ def install_dependent_packages(setup_py_file_path, dependency_type, temp_dir):

additional_filter_fn = None
if dependency_type == "Minimum":
additionalFilterFn = handle_incompatible_minimum_dev_reqs
additional_filter_fn = handle_incompatible_minimum_dev_reqs

# before september 2024, filter_dev_requirements only would remove any packages present in released_packages from the dev_requirements,
# then create a new file "new_dev_requirements.txt" without the problematic packages.
# after september 2024, filter_dev_requirements will also check for **compatibility** with the packages being installed when filtering the dev_requirements.
dev_req_file_path = filter_dev_requirements(setup_py_file_path, released_packages, temp_dir, additionalFilterFn)
dev_req_file_path = filter_dev_requirements(setup_py_file_path, released_packages, temp_dir, additional_filter_fn)

if override_added_packages:
logging.info(f"Expanding the requirement set by the packages {override_added_packages}.")
Expand Down