address review comments

sdk/ml/azure-ai-ml/.pre-commit-config.yaml

@@ -41,7 +41,7 @@ repos:
                     "https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-python/pypi/simple/",
                 ],
             ),
-            ("pylint", "3.0.3", []),
+            ("pylint", "3.2.7", []),
         ]
 
         # Make sure that correct versions are installed

sdk/ml/azure-ai-ml/azure/ai/ml/_ml_client.py

@@ -384,7 +384,11 @@ def __init__(
 
         self._service_client_10_2024_preview = ServiceClient102024Preview(
             credential=self._credential,
-            subscription_id=self._operation_scope._subscription_id,
+            subscription_id=(
+                self._ws_operation_scope._subscription_id
+                if registry_reference
+                else self._operation_scope._subscription_id
+            ),
             base_url=base_url,
             **kwargs,
         )

sdk/ml/azure-ai-ml/samples/ml_samples_workspace.py

@@ -16,9 +16,11 @@
 """
 
 import os
+
+from ml_samples_compute import handle_resource_exists_error
+
 from azure.ai.ml import MLClient
 from azure.identity import DefaultAzureCredential
-from ml_samples_compute import handle_resource_exists_error
 
 subscription_id = os.environ["AZURE_SUBSCRIPTION_ID"]
 resource_group = os.environ["RESOURCE_GROUP_NAME"]
@@ -74,13 +76,14 @@ def ml_workspace_config_sample_snippets_entities(self):
         # [END customermanagedkey]
 
         # [START workspace_managed_network]
+        from azure.ai.ml.constants._workspace import FirewallSku
         from azure.ai.ml.entities import (
-            Workspace,
-            ManagedNetwork,
+            FqdnDestination,
             IsolationMode,
-            ServiceTagDestination,
+            ManagedNetwork,
             PrivateEndpointDestination,
-            FqdnDestination,
+            ServiceTagDestination,
+            Workspace,
         )
 
         # Example private endpoint outbound to a blob
@@ -99,9 +102,13 @@ def ml_workspace_config_sample_snippets_entities(self):
         # Example FQDN rule
         pypirule = FqdnDestination(name="pypirule", destination="pypi.org")
 
+        # Example FirewallSku
+        firewallSku = FirewallSku.BASIC
+
         network = ManagedNetwork(
             isolation_mode=IsolationMode.ALLOW_ONLY_APPROVED_OUTBOUND,
             outbound_rules=[blobrule, datafactoryrule, pypirule],
+            firewall_sku=firewallSku,
         )
 
         # Workspace configuration
@@ -230,8 +237,7 @@ def ml_workspace_config_sample_snippets_operations(self):
 
         # [START create_or_update_connection]
         from azure.ai.ml import MLClient
-        from azure.ai.ml.entities import WorkspaceConnection
-        from azure.ai.ml.entities import UsernamePasswordConfiguration
+        from azure.ai.ml.entities import UsernamePasswordConfiguration, WorkspaceConnection
 
         ml_client_ws = MLClient(credential, subscription_id, resource_group, workspace_name="test-ws")
         wps_connection = WorkspaceConnection(