Skip to content

Add firewallsku as ManagedNetwork property #37885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nethracs merged 18 commits into from
Nov 5, 2024
Merged

Add firewallsku as ManagedNetwork property #37885

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
9547415
Generated REST client for upcoming API version `v2024-10-01-preview`.
Oct 3, 2024
70f8393
Initial commit
Oct 11, 2024
170c134
Initial commit
Oct 11, 2024
a46784d
add new test for firewallsku
Oct 12, 2024
c5257d7
add new test for firewallsku
Oct 12, 2024
3bf2de8
Merge latest and resolve conflict
Oct 14, 2024
789f758
remove irrelevant changes
Oct 14, 2024
0af3a5a
Merge branch 'main' of https://github.com/Nethracs/azure-sdk-for-pyth…
Oct 15, 2024
b9eb92e
add addressprefix changes
Oct 15, 2024
31f3d59
Merge branch 'main' of https://github.com/Nethracs/azure-sdk-for-pyth…
Oct 16, 2024
5757272
Merge branch 'main' of https://github.com/Nethracs/azure-sdk-for-pyth…
Oct 17, 2024
91224b4
Merge branch 'main' of https://github.com/Nethracs/azure-sdk-for-pyth…
Oct 24, 2024
53cd243
address review comments
Oct 25, 2024
ddb877a
address review comments
Oct 25, 2024
6c8da7a
merge latest and resolve conflict
Oct 29, 2024
54422d4
Merge branch 'main' of https://github.com/Nethracs/azure-sdk-for-pyth…
Oct 29, 2024
cc7b5f1
reset the file in rest client
Oct 29, 2024
bdff0a2
address review comments
Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address review comments
  • Loading branch information
Nethra Sashikar committed Oct 25, 2024
commit ddb877afb827cfdd62bef8b5228e07f7cf6ee9a6
2 changes: 1 addition & 1 deletion sdk/ml/azure-ai-ml/azure/ai/ml/_schema/workspace/networking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def make(self, data, **kwargs):
outbound_rules = data.get("outbound_rules", False)

firewall_sku = data.get("firewall_sku", False)
firewall_sku_value = _snake_to_camel(data["firewall_sku"]) if firewall_sku else None
firewall_sku_value = _snake_to_camel(data["firewall_sku"]) if firewall_sku else FirewallSku.STANDARD

if outbound_rules:
return ManagedNetwork(
Expand Down