Skip to content

Evaluation: Fix the output_path parameter of evaluate API doesn't support relative path #38241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ninghu merged 8 commits into from
Nov 1, 2024
Merged

Evaluation: Fix the output_path parameter of evaluate API doesn't support relative path #38241

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
43f8c36
Fix output_path parameter doesn't support relative path
ninghu Oct 30, 2024
ac54be1
add comments
ninghu Oct 31, 2024
0f7b6ae
Merge branch 'main' into ninhu/output_path
ninghu Oct 31, 2024
646ace9
fix the test
ninghu Oct 31, 2024
dbeba1e
Merge branch 'main' into ninhu/output_path
ninghu Oct 31, 2024
7d5f3a3
update
ninghu Oct 31, 2024
aea0f0c
minor update
ninghu Oct 31, 2024
11f076d
update
ninghu Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update
  • Loading branch information
@ninghu
ninghu committed Oct 31, 2024
commit 7d5f3a30dd1baa0ff5eee560af1d1d0bb84fc8e9
4 changes: 2 additions & 2 deletions sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluate/_evaluate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,9 +888,9 @@ def eval_batch_run(
result_df_dict = result_df.to_dict("records")
result: EvaluationResult = {"rows": result_df_dict, "metrics": metrics, "studio_url": studio_url} # type: ignore

_print_summary(per_evaluator_results)

if output_path:
_write_output(output_path, result)

_print_summary(per_evaluator_results)

return result
2 changes: 2 additions & 0 deletions sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluate/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,8 @@ def _write_output(path: Union[str, os.PathLike], data_dict: Any) -> None:
with open(p, "w", encoding=DefaultOpenEncoding.WRITE) as f:
json.dump(data_dict, f)

print(f"\nEvaluation results saved to {p.resolve()}")


def _apply_column_mapping(
source_df: pd.DataFrame, mapping_config: Optional[Dict[str, str]], inplace: bool = False
Expand Down