Sync eng/common directory with azure-sdk-tools for PR 10749 #42368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes the eng/common directory with azure-sdk-tools repository changes from PR 10749. The changes focus on improving the logic for handling deployment output files in the test resources helper script.
Key changes:
- Refactored conditional logic for output file handling to improve readability and maintainability
- Added clearer comments to explain when different output file formats are used
- Extracted Bicep file detection into a reusable variable
Comments suppressed due to low confidence (1)
eng/common/TestResources/TestResources-Helpers.ps1:304
- This closing brace appears to be incorrectly placed or redundant. The refactored conditional structure should have proper brace alignment, but this brace doesn't seem to match any opening brace in the visible diff context.
}
heaths
approved these changes
Aug 5, 2025
weshaggard
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#10749 See eng/common workflow