-
Notifications
You must be signed in to change notification settings - Fork 227
Make sure we print env vars for JSON ARM templates #10749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the environment-output logic to add explicit handling for Bicep templates and consolidates the Windows/.NET branch.
- Introduces an
$isBicepflag for Bicep template detection - Merges the
.envoutput conditions into singleif/elseifstatements - Adds contextual comments for .NET encryption and Bicep handling
Comments suppressed due to low confidence (1)
eng/common/TestResources/TestResources-Helpers.ps1:267
- Variable
$isBicepshould be PascalCased (e.g.$IsBicep) to align with PowerShell variable naming conventions used elsewhere ($OutFile,$IsWindows).
$isBicep = $templateFile.originalFilePath -and $templateFile.originalFilePath.EndsWith(".bicep")
|
The following pipelines have been queued for testing: |
|
Hi @heaths. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#10749 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Heath Stewart <[email protected]>
|
Merged this because eng/common sync had already completed. |
Fixes #10734