Skip to content

Conversation

@heaths
Copy link
Member

@heaths heaths commented May 27, 2025

Fixes #10734

@heaths heaths requested review from LarryOsterman and Copilot May 27, 2025 22:10
@heaths heaths requested a review from a team as a code owner May 27, 2025 22:10
@heaths heaths requested review from benbp and weshaggard May 27, 2025 22:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the environment-output logic to add explicit handling for Bicep templates and consolidates the Windows/.NET branch.

  • Introduces an $isBicep flag for Bicep template detection
  • Merges the .env output conditions into single if/elseif statements
  • Adds contextual comments for .NET encryption and Bicep handling
Comments suppressed due to low confidence (1)

eng/common/TestResources/TestResources-Helpers.ps1:267

  • Variable $isBicep should be PascalCased (e.g. $IsBicep) to align with PowerShell variable naming conventions used elsewhere ($OutFile, $IsWindows).
$isBicep = $templateFile.originalFilePath -and $templateFile.originalFilePath.EndsWith(".bicep")

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@github-actions
Copy link

github-actions bot commented Aug 1, 2025

Hi @heaths. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Aug 1, 2025
@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label Aug 1, 2025
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Aug 5, 2025
@benbp benbp merged commit 687bd5e into Azure:main Aug 6, 2025
7 checks passed
@benbp
Copy link
Member

benbp commented Aug 6, 2025

Merged this because eng/common sync had already completed.

@heaths heaths deleted the issue10734 branch August 6, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new-testresources.ps1 won't output environment variables if the servicedirectory doesn't contain a test-resources.bicep file

5 participants