[Core] Handle requests connection timeout error #7542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
annatisch
added
Azure.Core
Client
This was referenced Oct 1, 2019
bryevdv
approved these changes
Oct 1, 2019
Contributor
|
Build failure looks like an Eng problem
|
Member
Author
|
ping @xiangyan99 and @lmazuel for review :) |
xiangyan99
approved these changes
Oct 3, 2019
YijunXieMS
pushed a commit
to YijunXieMS/azure-sdk-for-python
that referenced
this pull request
Oct 9, 2019
* Handle requests connection timeout error * Moved catch * Added test * Update test to be more stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user specifies a
connection_timeoutparameter on a request, this will raise a urllib3 ConnectTimeout exception, which is not currently handled in the transport, and instead is raised straight to users. Which means it also bypasses the retry policy.