[Cosmos] Reconfigure retry policy #7544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annatisch
added
Cosmos
Client
|
Can one of the admins verify this patch? |
bryevdv
reviewed
Oct 1, 2019
bryevdv
approved these changes
Oct 1, 2019
Contributor
|
one small comment, LGTM |
bryevdv
reviewed
Oct 2, 2019
Member
Author
|
Ping @johanste, @srinathnarayanan :) |
srinathnarayanan
approved these changes
Oct 3, 2019
johanste
reviewed
Oct 3, 2019
| while True: | ||
| try: | ||
| client_timeout = kwargs.get('timeout') | ||
| start_time = time.time() |
Member
There was a problem hiding this comment.
Should this be outside the loop?
Member
Author
There was a problem hiding this comment.
Thanks @johanste
I don't think so - we calculate the time spent for each loop iteration and deduct it from the absolute timeout, which we then feed back into kwargs on line 122 - so I think it's correct to do this with each iteration
annatisch
added a commit
that referenced
this pull request
Oct 9, 2019
* [Cosmos] Reconfigure retry policy (#7544) * Reconfigure retry policy * Review feedback * Fix pylint * Updated tests * Support client-side timeout * Updated timeout logic * Renamed client error * Updated tests * Patch azure-core Needed pending PR 7542 * Fixed status retry tests * Using dev core * [Cosmos] Docs updates (#7626) * Updated sample refs * Added release notes * Remove old rst files * Fixed kwarg formatting * add sdk tools repo (#7656) * [Cosmos] More docs cleanup (#7661) * Removed old docs * Bumped core version * Removed submodule docs * Fixed imports * Pylint fix * More docs updates * Fixed docstring types * Docstring formatting * Updated snippet references * Fixed exception docs * More exception docstrings * Review feedback * [Cosmos] Live test updates (#7693) * Live test fixes * Emulator test fixes * Emulator test fixes * Fix urllib3 reference
YijunXieMS
pushed a commit
to YijunXieMS/azure-sdk-for-python
that referenced
this pull request
Oct 9, 2019
* [Cosmos] Reconfigure retry policy (Azure#7544) * Reconfigure retry policy * Review feedback * Fix pylint * Updated tests * Support client-side timeout * Updated timeout logic * Renamed client error * Updated tests * Patch azure-core Needed pending PR 7542 * Fixed status retry tests * Using dev core * [Cosmos] Docs updates (Azure#7626) * Updated sample refs * Added release notes * Remove old rst files * Fixed kwarg formatting * add sdk tools repo (Azure#7656) * [Cosmos] More docs cleanup (Azure#7661) * Removed old docs * Bumped core version * Removed submodule docs * Fixed imports * Pylint fix * More docs updates * Fixed docstring types * Docstring formatting * Updated snippet references * Fixed exception docs * More exception docstrings * Review feedback * [Cosmos] Live test updates (Azure#7693) * Live test fixes * Emulator test fixes * Emulator test fixes * Fix urllib3 reference
annatisch
pushed a commit
that referenced
this pull request
Oct 11, 2019
* intiial commit for query piepline changes * initial commit for offset and limit * modified aggregate tests to check for top as well after bugfix * Added support for distinct * modified aggregate tests to run in mono repo * fixed failing tests and bugs * updated tests * fixed hashing problem for distinct * fixed bug in distinct queries * replaced single quotes with double quotes * re introduced hashing via sha1 * fixed bug in distinct for py3 * dummy commit * dummy commit * [Cosmos] Core pipeline integration (#6961) * Updated dependencies * Added core pipeline * Ignore test config * Fixed indexes test * Refactored request creation * Fixed index test * Added trace decorators * Bumped version * Updated policies * Renamed request_options -> request_params * [Cosmos] Applying track 2 SDK guidelines (#7021) * Updated dependencies * Added core pipeline * Ignore test config * Fixed indexes test * Refactored request creation * Fixed index test * Added trace decorators * Bumped version * Updated policies * Renamed request_options -> request_params * Renamed clients * Updated with azure-core errors * Fixed test warnings * Updated config * PR fixes * Fixed init user import * Fixed init clients * Started revising constructors * Test conn str constructor * Update iterables with core paging * Added context managers * Reverted storage changes * Updated constructor * Mypy and Pylint * Renamed all listing operations * Some mypy fixes * Cleaned up method signatures * Fix pylint * Propagate kwargs * Fix pylint * Some mypy fixes * Updated readme and release notes * Fix for passing in extra headers * Reverted credentials * Review feedback * Fix pylint * Fixed samples * Updated docstrings * Fixed whitespace and imports * Some mypy fixes * Mypy fixes * Removed continuation token support * Pylint fix * Docs tweaks * Updated continuation token * Updated response header * Added support for Urllib3 Connection retries Made Offer extend object instead of dict * [Cosmos] Bumped dependency (#7147) * Bumped dependency * Update reqs * Misc fixes for Cosmos SDK (#7157) * Made offer extend object instead of dict * added support for urllib3 connection retry * [Cosmos] Reconfigure retry policy (#7544) * Reconfigure retry policy * Review feedback * Fix pylint * Updated tests * Support client-side timeout * Updated timeout logic * Renamed client error * Updated tests * Patch azure-core Needed pending PR 7542 * Fixed status retry tests * Using dev core * [Cosmos] Docs updates (#7626) * Updated sample refs * Added release notes * Remove old rst files * Fixed kwarg formatting * add sdk tools repo (#7656) * [Cosmos] More docs cleanup (#7661) * Removed old docs * Bumped core version * Removed submodule docs * Fixed imports * Pylint fix * More docs updates * Fixed docstring types * Docstring formatting * Updated snippet references * Fixed exception docs * More exception docstrings * Review feedback * dummy commit * reverted dummy commit * fixed failing test fixed lint errors * fixed failing tests * updated comment * added **kwargs to _GetQueryPlanThroughGateway
annatisch
added a commit
that referenced
this pull request
Oct 31, 2019
* Query pipeline changes and Offset/Limit/Distinct support (#6770) * intiial commit for query piepline changes * initial commit for offset and limit * modified aggregate tests to check for top as well after bugfix * Added support for distinct * modified aggregate tests to run in mono repo * fixed failing tests and bugs * updated tests * fixed hashing problem for distinct * fixed bug in distinct queries * replaced single quotes with double quotes * re introduced hashing via sha1 * fixed bug in distinct for py3 * dummy commit * dummy commit * [Cosmos] Core pipeline integration (#6961) * Updated dependencies * Added core pipeline * Ignore test config * Fixed indexes test * Refactored request creation * Fixed index test * Added trace decorators * Bumped version * Updated policies * Renamed request_options -> request_params * [Cosmos] Applying track 2 SDK guidelines (#7021) * Updated dependencies * Added core pipeline * Ignore test config * Fixed indexes test * Refactored request creation * Fixed index test * Added trace decorators * Bumped version * Updated policies * Renamed request_options -> request_params * Renamed clients * Updated with azure-core errors * Fixed test warnings * Updated config * PR fixes * Fixed init user import * Fixed init clients * Started revising constructors * Test conn str constructor * Update iterables with core paging * Added context managers * Reverted storage changes * Updated constructor * Mypy and Pylint * Renamed all listing operations * Some mypy fixes * Cleaned up method signatures * Fix pylint * Propagate kwargs * Fix pylint * Some mypy fixes * Updated readme and release notes * Fix for passing in extra headers * Reverted credentials * Review feedback * Fix pylint * Fixed samples * Updated docstrings * Fixed whitespace and imports * Some mypy fixes * Mypy fixes * Removed continuation token support * Pylint fix * Docs tweaks * Updated continuation token * Updated response header * Added support for Urllib3 Connection retries Made Offer extend object instead of dict * [Cosmos] Bumped dependency (#7147) * Bumped dependency * Update reqs * Misc fixes for Cosmos SDK (#7157) * Made offer extend object instead of dict * added support for urllib3 connection retry * [Cosmos] Reconfigure retry policy (#7544) * Reconfigure retry policy * Review feedback * Fix pylint * Updated tests * Support client-side timeout * Updated timeout logic * Renamed client error * Updated tests * Patch azure-core Needed pending PR 7542 * Fixed status retry tests * Using dev core * [Cosmos] Docs updates (#7626) * Updated sample refs * Added release notes * Remove old rst files * Fixed kwarg formatting * add sdk tools repo (#7656) * [Cosmos] More docs cleanup (#7661) * Removed old docs * Bumped core version * Removed submodule docs * Fixed imports * Pylint fix * More docs updates * Fixed docstring types * Docstring formatting * Updated snippet references * Fixed exception docs * More exception docstrings * Review feedback * dummy commit * reverted dummy commit * fixed failing test fixed lint errors * fixed failing tests * updated comment * added **kwargs to _GetQueryPlanThroughGateway * Move cosmos errors.py -> exceptions.py (#8226) * errors.py -> exceptions.py * add deprecated errors.py stub * update changelog * linter * add reprs to common user-facing classes (#8241) * add reprs to common user-facing classes * typo class name * disable errant linter objection * [Cosmos] Live test fixes (#8245) * Cosmos live test fixes * Another test fix * Update tests for old emulator * Removed disabled tests * [Cosmos] Updates to kwargs and docstrings (#8277) * Made version file internal * Updated kwargs * Updated docstrings * Updated access condition kwargs * More docs cleanup * Whitespace * Removed URLs for now * Fix samples merge * Updated conditional param parsing * Fixed type hint * Removed samples init * Added match condition validation tests * fix Cosmos README 404s (#8304) * fix Cosmos README 404s * typo * Typo
fengzhou-msft
pushed a commit
that referenced
this pull request
Nov 5, 2019
* [Cosmos] Reconfigure retry policy (#7544) * Reconfigure retry policy * Review feedback * Fix pylint * Updated tests * Support client-side timeout * Updated timeout logic * Renamed client error * Updated tests * Patch azure-core Needed pending PR 7542 * Fixed status retry tests * Using dev core * [Cosmos] Docs updates (#7626) * Updated sample refs * Added release notes * Remove old rst files * Fixed kwarg formatting * add sdk tools repo (#7656) * [Cosmos] More docs cleanup (#7661) * Removed old docs * Bumped core version * Removed submodule docs * Fixed imports * Pylint fix * More docs updates * Fixed docstring types * Docstring formatting * Updated snippet references * Fixed exception docs * More exception docstrings * Review feedback * [Cosmos] Live test updates (#7693) * Live test fixes * Emulator test fixes * Emulator test fixes * Fix urllib3 reference
fengzhou-msft
pushed a commit
that referenced
this pull request
Nov 5, 2019
* Query pipeline changes and Offset/Limit/Distinct support (#6770) * intiial commit for query piepline changes * initial commit for offset and limit * modified aggregate tests to check for top as well after bugfix * Added support for distinct * modified aggregate tests to run in mono repo * fixed failing tests and bugs * updated tests * fixed hashing problem for distinct * fixed bug in distinct queries * replaced single quotes with double quotes * re introduced hashing via sha1 * fixed bug in distinct for py3 * dummy commit * dummy commit * [Cosmos] Core pipeline integration (#6961) * Updated dependencies * Added core pipeline * Ignore test config * Fixed indexes test * Refactored request creation * Fixed index test * Added trace decorators * Bumped version * Updated policies * Renamed request_options -> request_params * [Cosmos] Applying track 2 SDK guidelines (#7021) * Updated dependencies * Added core pipeline * Ignore test config * Fixed indexes test * Refactored request creation * Fixed index test * Added trace decorators * Bumped version * Updated policies * Renamed request_options -> request_params * Renamed clients * Updated with azure-core errors * Fixed test warnings * Updated config * PR fixes * Fixed init user import * Fixed init clients * Started revising constructors * Test conn str constructor * Update iterables with core paging * Added context managers * Reverted storage changes * Updated constructor * Mypy and Pylint * Renamed all listing operations * Some mypy fixes * Cleaned up method signatures * Fix pylint * Propagate kwargs * Fix pylint * Some mypy fixes * Updated readme and release notes * Fix for passing in extra headers * Reverted credentials * Review feedback * Fix pylint * Fixed samples * Updated docstrings * Fixed whitespace and imports * Some mypy fixes * Mypy fixes * Removed continuation token support * Pylint fix * Docs tweaks * Updated continuation token * Updated response header * Added support for Urllib3 Connection retries Made Offer extend object instead of dict * [Cosmos] Bumped dependency (#7147) * Bumped dependency * Update reqs * Misc fixes for Cosmos SDK (#7157) * Made offer extend object instead of dict * added support for urllib3 connection retry * [Cosmos] Reconfigure retry policy (#7544) * Reconfigure retry policy * Review feedback * Fix pylint * Updated tests * Support client-side timeout * Updated timeout logic * Renamed client error * Updated tests * Patch azure-core Needed pending PR 7542 * Fixed status retry tests * Using dev core * [Cosmos] Docs updates (#7626) * Updated sample refs * Added release notes * Remove old rst files * Fixed kwarg formatting * add sdk tools repo (#7656) * [Cosmos] More docs cleanup (#7661) * Removed old docs * Bumped core version * Removed submodule docs * Fixed imports * Pylint fix * More docs updates * Fixed docstring types * Docstring formatting * Updated snippet references * Fixed exception docs * More exception docstrings * Review feedback * dummy commit * reverted dummy commit * fixed failing test fixed lint errors * fixed failing tests * updated comment * added **kwargs to _GetQueryPlanThroughGateway * Move cosmos errors.py -> exceptions.py (#8226) * errors.py -> exceptions.py * add deprecated errors.py stub * update changelog * linter * add reprs to common user-facing classes (#8241) * add reprs to common user-facing classes * typo class name * disable errant linter objection * [Cosmos] Live test fixes (#8245) * Cosmos live test fixes * Another test fix * Update tests for old emulator * Removed disabled tests * [Cosmos] Updates to kwargs and docstrings (#8277) * Made version file internal * Updated kwargs * Updated docstrings * Updated access condition kwargs * More docs cleanup * Whitespace * Removed URLs for now * Fix samples merge * Updated conditional param parsing * Fixed type hint * Removed samples init * Added match condition validation tests * fix Cosmos README 404s (#8304) * fix Cosmos README 404s * typo * Typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for connection retry as a Pipeline policy rather than adding a urllib Retry object to the session.
Should be 99% backwards compatible.
Tests will require this fix for azure-core in order to pass: PR #7542