Skip to content

[Cosmos] Preview 4 #7621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
annatisch merged 9 commits into from
Oct 9, 2019
Merged

[Cosmos] Preview 4 #7621

annatisch merged 9 commits into from
Oct 9, 2019

Conversation

@annatisch
Copy link
Member

@annatisch annatisch commented Oct 4, 2019

No description provided.

@annatisch
[Cosmos] Reconfigure retry policy (#7544)
962391c 
* Reconfigure retry policy

* Review feedback

* Fix pylint

* Updated tests

* Support client-side timeout

* Updated timeout logic

* Renamed client error

* Updated tests

* Patch azure-core

Needed pending PR 7542

* Fixed status retry tests

* Using dev core
@annatisch
Merge remote-tracking branch 'origin/master' into feature/cosmos-prev…
6b70f06 
…iew4
@annatisch annatisch requested a review from shurd as a code owner October 4, 2019 20:12
@adxsdk6
Copy link

adxsdk6 commented Oct 4, 2019

Can one of the admins verify this patch?

@annatisch
[Cosmos] Docs updates (#7626)
dc9ca57 
* Updated sample refs

* Added release notes

* Remove old rst files

* Fixed kwarg formatting
@annatisch
Merge remote-tracking branch 'origin/master' into feature/cosmos-prev…
96ad56a 
…iew4
@codecov-io
Copy link

codecov-io commented Oct 7, 2019 •
edited
Loading

Codecov Report

Merging #7621 into master will decrease coverage by 5%.
The diff coverage is 14.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7621      +/-   ##
==========================================
- Coverage   31.25%   26.24%   -5.01%     
==========================================
  Files          45       64      +19     
  Lines        3603     5802    +2199     
==========================================
+ Hits         1126     1523     +397     
- Misses       2477     4279    +1802
Impacted Files Coverage Δ
sdk/cosmos/azure-cosmos/test/crud_tests.py 9.55% <14.75%> (ø)
...ub/azure-eventhubs/azure/eventhub/configuration.py
...re-eventhubs/tests/livetest/synctests/test_auth.py
...nthubs/tests/livetest/synctests/test_properties.py
.../eventhub/azure-eventhubs/azure/eventhub/client.py
...enthubs/azure/eventhub/aio/eventprocessor/utils.py
...re-eventhubs/tests/livetest/synctests/test_send.py
...nthubs/tests/eventprocessor/test_eventprocessor.py
...k/eventhub/azure-eventhubs/azure/eventhub/error.py
...hub/aio/eventprocessor/sample_partition_manager.py
... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af719b1...81d96ce. Read the comment docs.

@annatisch
Copy link
Member Author

annatisch commented Oct 7, 2019

/azp run python - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 7, 2019

Azure Pipelines failed to run 1 pipeline(s).

@danieljurek
Copy link
Member

danieljurek commented Oct 7, 2019

/azp run python - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 7, 2019

Azure Pipelines failed to run 1 pipeline(s).

@annatisch annatisch requested a review from danieljurek as a code owner October 7, 2019 18:52
@annatisch
Merge remote-tracking branch 'origin/master' into feature/cosmos-prev…
c0d0967 
…iew4
@annatisch
[Cosmos] More docs cleanup (#7661)
81d96ce 
* Removed old docs

* Bumped core version

* Removed submodule docs

* Fixed imports

* Pylint fix

* More docs updates

* Fixed docstring types

* Docstring formatting

* Updated snippet references

* Fixed exception docs

* More exception docstrings

* Review feedback
@annatisch
Copy link
Member Author

annatisch commented Oct 8, 2019

/azp run python - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 8, 2019

Azure Pipelines successfully started running 1 pipeline(s).

lmazuel
lmazuel reviewed Oct 8, 2019
View reviewed changes
lmazuel
lmazuel reviewed Oct 8, 2019
View reviewed changes
lmazuel
lmazuel approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

urllib3 import should be changed, and beware of "kwargs attack" (unexpected kwargs at the receiver ends, requests for instance will raise if it receives any kwargs he doesn't know)

@annatisch
Merge remote-tracking branch 'origin/master' into feature/cosmos-prev…
dcbbacf 
…iew4
@annatisch
[Cosmos] Live test updates (#7693)
b110a1a 
* Live test fixes

* Emulator test fixes

* Emulator test fixes

* Fix urllib3 reference
@annatisch
Copy link
Member Author

annatisch commented Oct 9, 2019

/azp run python - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 9, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@annatisch annatisch merged commit f603690 into master Oct 9, 2019
YijunXieMS pushed a commit to YijunXieMS/azure-sdk-for-python that referenced this pull request Oct 9, 2019
@annatisch
[Cosmos] Preview 4 (Azure#7621)
1f24bab 
* [Cosmos] Reconfigure retry policy (Azure#7544)

* Reconfigure retry policy

* Review feedback

* Fix pylint

* Updated tests

* Support client-side timeout

* Updated timeout logic

* Renamed client error

* Updated tests

* Patch azure-core

Needed pending PR 7542

* Fixed status retry tests

* Using dev core

* [Cosmos] Docs updates (Azure#7626)

* Updated sample refs

* Added release notes

* Remove old rst files

* Fixed kwarg formatting

* add sdk tools repo (Azure#7656)

* [Cosmos] More docs cleanup (Azure#7661)

* Removed old docs

* Bumped core version

* Removed submodule docs

* Fixed imports

* Pylint fix

* More docs updates

* Fixed docstring types

* Docstring formatting

* Updated snippet references

* Fixed exception docs

* More exception docstrings

* Review feedback

* [Cosmos] Live test updates (Azure#7693)

* Live test fixes

* Emulator test fixes

* Emulator test fixes

* Fix urllib3 reference
@annatisch annatisch deleted the feature/cosmos-preview4 branch October 9, 2019 21:28
fengzhou-msft pushed a commit that referenced this pull request Nov 5, 2019
@annatisch @fengzhou-msft
[Cosmos] Preview 4 (#7621)
9520866 
* [Cosmos] Reconfigure retry policy (#7544)

* Reconfigure retry policy

* Review feedback

* Fix pylint

* Updated tests

* Support client-side timeout

* Updated timeout logic

* Renamed client error

* Updated tests

* Patch azure-core

Needed pending PR 7542

* Fixed status retry tests

* Using dev core

* [Cosmos] Docs updates (#7626)

* Updated sample refs

* Added release notes

* Remove old rst files

* Fixed kwarg formatting

* add sdk tools repo (#7656)

* [Cosmos] More docs cleanup (#7661)

* Removed old docs

* Bumped core version

* Removed submodule docs

* Fixed imports

* Pylint fix

* More docs updates

* Fixed docstring types

* Docstring formatting

* Updated snippet references

* Fixed exception docs

* More exception docstrings

* Review feedback

* [Cosmos] Live test updates (#7693)

* Live test fixes

* Emulator test fixes

* Emulator test fixes

* Fix urllib3 reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmazuel lmazuel lmazuel approved these changes

@shurd shurd Awaiting requested review from shurd

@danieljurek danieljurek Awaiting requested review from danieljurek

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@annatisch @adxsdk6 @codecov-io @danieljurek @lmazuel