This repository was archived by the owner on Jan 11, 2023. It is now read-only.
[rake arm:release] Rescue error while publishing #972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veronicagg
approved these changes
Sep 12, 2017
Contributor
veronicagg
left a comment
veronicagg
left a comment
There was a problem hiding this comment.
Approving as a temporary fix for recent publish transient error.
| # Using execute method so that keys are not logged onto console | ||
| execute("gem push ./pkg/#{dir}-#{version}.gem" + (args[:key].nil? ? '' : " -k #{args[:key]}")) | ||
| rescue Exception => ex | ||
| puts "Error occurred while publishing #{dir}: #{ex}" |
Contributor
There was a problem hiding this comment.
I would do caps on "ERROR"
Contributor
Author
There was a problem hiding this comment.
that's true but i'll revert this changes once we release :)
Contributor
Author
|
Thanks for the quick review!! |
vishrutshah
added a commit
that referenced
this pull request
Sep 12, 2017
This reverts commit 59eeea5.
vishrutshah
added a commit
to vishrutshah/azure-sdk-for-ruby
that referenced
this pull request
Sep 12, 2017
This reverts commit 59eeea5.
vishrutshah
added a commit
that referenced
this pull request
Sep 12, 2017
vishrutshah
added a commit
to vishrutshah/azure-sdk-for-ruby
that referenced
this pull request
Sep 27, 2017
vishrutshah
added a commit
that referenced
this pull request
Sep 27, 2017
vishrutshah
added a commit
that referenced
this pull request
Sep 28, 2017
vishrutshah
added a commit
that referenced
this pull request
Sep 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swallowing errors while publishing to allow publishing of the only new version of the gems