This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Revert "[rake arm:release] Rescue error while publishing (#972)" #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 59eeea5.
vishrutshah
added
ARM
bug
veronicagg
approved these changes
Sep 12, 2017
Contributor
Author
|
Thanks again for the quick review!! |
vishrutshah
added a commit
to vishrutshah/azure-sdk-for-ruby
that referenced
this pull request
Sep 27, 2017
vishrutshah
added a commit
that referenced
this pull request
Sep 27, 2017
vishrutshah
added a commit
that referenced
this pull request
Sep 28, 2017
vishrutshah
added a commit
that referenced
this pull request
Sep 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 59eeea5.
The reason we added this change was to make sure even one of the gem publish fails we can still try releasing other gems. This was a temporary change but once we have publishing story for individual gem we'll be able to better control how we release an each gem.
cc: @sarangan12 Let's talk about this in case you were working on release story task :)