Skip to content

Conversation

@tnorling
Copy link
Collaborator

@tnorling tnorling commented Jun 17, 2020

Waiting for response_type changes from #2022 as the lab instance does not support token type

@github-actions github-actions bot added msal-browser Related to msal-browser package msal-common Related to msal-common package labels Jun 17, 2020
@github-actions github-actions bot added the samples Related to the samples apps for the library. label Jun 17, 2020
@tnorling tnorling mentioned this pull request Jun 17, 2020
@tnorling tnorling removed msal-browser Related to msal-browser package msal-common Related to msal-common package labels Jun 17, 2020
@tnorling tnorling marked this pull request as ready for review June 23, 2020 19:15
Copy link
Contributor

@jasonnutter jasonnutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing otherwise lgtm.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2020

This PR has not seen activity in 14 days. It may be closed if it remains stale.

@github-actions github-actions bot added the no-pr-activity PR has been inactive for 14 days label Jul 9, 2020
@tnorling tnorling added this to the [email protected] - Release milestone Aug 10, 2020
@tnorling tnorling changed the base branch from msal-core-adfs to 1.4.0-release August 17, 2020 18:30
Copy link
Member

@hectormmg hectormmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits, but LGTM!

@tnorling tnorling merged commit 2e2116d into 1.4.0-release Aug 18, 2020
@tnorling tnorling mentioned this pull request Aug 24, 2020
@tnorling tnorling deleted the adfs-sample branch October 19, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-pr-activity PR has been inactive for 14 days samples Related to the samples apps for the library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants