Skip to content
This repository was archived by the owner on May 13, 2025. It is now read-only.

Conversation

@deeksha345
Copy link


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

FumingZhang and others added 30 commits November 22, 2022 10:38
* feat: application accelerator cli

* feat: predefined accelerator cli

* feat: customized accelerator cli

* fix: change back `add` to `create`

* fix:change as pre comments

* fix: update spring extension version

* fix: change as pre comments

* fix: private key \n convert issue

* fix: code style issue

* fix: linter issue

* fix: add is preview to command group

* fix: add confirmation=True

* fix: add comments for using "record_only()" lable
…vey link (Azure#5568)

* remove the dependency on azure storage file

* fix dependency issue

* update survey link

* refine storage sdk logic
* [AKS] refine creating TA binding commands

* add tests for TA

* history

* refine

* recording

* remove live only

Co-authored-by: Yitong Feng <[email protected]>
…t it won't be affected by 22.04 switch over at k8s 1.25.2 (Azure#5580)

Co-authored-by: Charlie Li <[email protected]>
…5582)

* update param declare

* fix help lint

* remove useless declaration
charliedmcb and others added 16 commits January 19, 2023 11:01
* Update version

* Update

* Remove 3.6 in CLASSIFIERS
* partner center extension

* fixing hash

* removing duplicate entry

* updating partnercenter reference in index

* adding partnercenter to service name list

* fixing service name, updating index to the latest version of partner center extension
…re#5788)

* add --node-os-upgrade-channel to create and update

* add exclusion

* fix linter

* order imports?

* remove instances of self._ensure_mc(mc)

* add help text

* cleanup help comment

* remove default comment

* add version bump

* switched to node_os_upgrade_channels

* remove whitespace

* rerun tests with current setup

* Update src/aks-preview/azext_aks_preview/_help.py

Co-authored-by: FumingZhang <[email protected]>

* Update src/aks-preview/azext_aks_preview/_help.py

Co-authored-by: FumingZhang <[email protected]>

* remove whitespace

Co-authored-by: Charlie McBride <[email protected]>
Co-authored-by: FumingZhang <[email protected]>
* update readme

* update history
@deeksha345 deeksha345 enabled auto-merge January 23, 2023 20:43
bavneetsingh16
bavneetsingh16 previously approved these changes Jan 23, 2023
Copy link

@bavneetsingh16 bavneetsingh16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@bavneetsingh16 bavneetsingh16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deeksha345 deeksha345 merged commit 8319907 into k8s-extension/public Jan 23, 2023
@deeksha345 deeksha345 deleted the release-1.3.8 branch January 23, 2023 23:38
Arif-lakhani pushed a commit that referenced this pull request Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.