Fixes Android pubspec #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 052a9f8.
mvanbeusekom
requested changes
Mar 13, 2023
Member
mvanbeusekom
left a comment
mvanbeusekom
left a comment
There was a problem hiding this comment.
I think it is better to make the version number represent a hotfix.
| @@ -1,3 +1,7 @@ | |||
| ## 1.0.1 | |||
Member
There was a problem hiding this comment.
This might be considered a hotfix. In this case I would update the version to:
Suggested change
| ## 1.0.1 | |
| ## 1.0.0+1 |
| # NOTE: We strongly prefer non-breaking changes, even at the expense of a | ||
| # less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes | ||
| version: 1.0.0 | ||
| version: 1.0.1 |
Member
There was a problem hiding this comment.
hotfix version bump:
Suggested change
| version: 1.0.1 | |
| version: 1.0.0+1 |
…com:jeroenweener/flutter-google-api-availability into enhancement/finalize-federated-architecture
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Adds the
dartPluginClassdeclaration to the pubspec.💥 Does this PR introduce a breaking change?
No.
📝 Links to relevant issues/docs
This PR is part of the journey to transitioning to the federated plugin architecture. See #33.
🤔 Checklist before submitting