Skip to content

Fixes Android pubspec #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvanbeusekom merged 3 commits into from
Mar 14, 2023
Merged

Fixes Android pubspec #39

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
964f72e
Revert "Revert "Fixes Android pubspec""
JeroenWeener Mar 13, 2023
f8c8f23
Changes versioning to hotfix
JeroenWeener Mar 14, 2023
d4039c7
Merge branch 'enhancement/finalize-federated-architecture' of github.…
JeroenWeener Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Revert "Revert "Fixes Android pubspec"" 
This reverts commit 052a9f8.
  • Loading branch information
@JeroenWeener
JeroenWeener committed Mar 13, 2023
commit 964f72e3aa05a89d84ae91c3687eec4c1270839f
4 changes: 4 additions & 0 deletions google_api_availability_android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.0.1
Copy link
Member

@mvanbeusekom mvanbeusekom Mar 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be considered a hotfix. In this case I would update the version to:

Suggested change
## 1.0.1
## 1.0.0+1


* Declares `dartPluginClass` in pubspec declaration.

## 1.0.0

* Extracts the Android platform implementation from the google_api_availability package.
3 changes: 2 additions & 1 deletion google_api_availability_android/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: An Android implementation for the google_api_availability plugin.
repository: https://github.com/baseflow/flutter-google-api-availability/tree/main/google_api_availability_android
# NOTE: We strongly prefer non-breaking changes, even at the expense of a
# less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes
version: 1.0.0
version: 1.0.1
Copy link
Member

@mvanbeusekom mvanbeusekom Mar 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hotfix version bump:

Suggested change
version: 1.0.1
version: 1.0.0+1


flutter:
plugin:
Expand All @@ -12,6 +12,7 @@ flutter:
android:
package: com.baseflow.googleapiavailability
pluginClass: GoogleApiAvailabilityPlugin
dartPluginClass: GoogleApiAvailabilityAndroid

dependencies:
flutter:
Expand Down