emscripten no longer provides sys/timex.h, but does provide sys/time.h #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenrussell
reviewed
Oct 7, 2022
Contributor
kenrussell
left a comment
kenrussell
left a comment
There was a problem hiding this comment.
Looks fine to me, and while I seem to have privileges to approve this, let's give Binomial a chance to review.
dschuff
reviewed
Oct 7, 2022
Contributor
dschuff
left a comment
dschuff
left a comment
There was a problem hiding this comment.
I think checking for emscripten instead of Wasm is better here; Wasm is the architecture and Emscripten is playing the role of the OS/SDK here. If you wanted to compile with some other Wasm SDK (e.g. wasi-sdk) in the future, it could potentially have a different set of include files.
Co-authored-by: Derek Schuff <[email protected]>
Contributor
|
Great catch @dschuff and thanks @walkingeyerobot for updating this. |
Contributor
|
Got it - I'm reviewing. |
Contributor
|
Got it thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See emscripten-core/emscripten#17704 for details.