[Web] Fix shutdown, force WebGL2, fix editor run args. #68292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faless
force-pushed
the
web/4.x_editor_fixes
branch
from
3422cbb to
59e7437
Compare
Collaborator
Author
|
Note, I built with emcc |
clayjohn
approved these changes
Nov 5, 2022
Member
clayjohn
left a comment
clayjohn
left a comment
There was a problem hiding this comment.
WebGL initialization stuff looks correct to me. I'm not qualified to have an opinion on the rest though.
akien-mga
approved these changes
Nov 5, 2022
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web Editor now works, can launch games.