Skip to content

Add try/catch logic to recording of analytics events #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2017
Merged

Add try/catch logic to recording of analytics events #950

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7cdafb
Add try/catch logic to recording of analytics events
clone1612 Oct 9, 2017
53d3f51
Cleaner catch
clone1612 Oct 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Cleaner catch
  • Loading branch information
@clone1612
clone1612 committed Oct 9, 2017
commit 53d3f51c74b29966237f23aba4fbbfab2d0991de
8 changes: 6 additions & 2 deletions browser/main/lib/AwsMobileAnalyticsConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ function recordDynamicCustomEvent (type) {
try {
mobileAnalyticsClient.recordEvent(type)
} catch (analyticsError) {
console.error(analyticsError)
if (analyticsError instanceof ReferenceError) {
console.log(analyticsError.name + ': ' + analyticsError.message)
}
}
}

Expand All @@ -40,7 +42,9 @@ function recordStaticCustomEvent () {
uiColorTheme: ConfigManager.default.get().ui.theme
})
} catch (analyticsError) {
console.error(analyticsError)
if (analyticsError instanceof ReferenceError) {
console.log(analyticsError.name + ': ' + analyticsError.message)
}
}
}

Expand Down