Skip to content

Add try/catch logic to recording of analytics events #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2017
Merged

Add try/catch logic to recording of analytics events #950

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7cdafb
Add try/catch logic to recording of analytics events
jhemelhof Oct 9, 2017
53d3f51
Cleaner catch
jhemelhof Oct 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add try/catch logic to recording of analytics events
  • Loading branch information
@jhemelhof
jhemelhof committed Oct 9, 2017
commit f7cdafb0878c66414ecb5024d85a760cfe7826af
16 changes: 12 additions & 4 deletions browser/main/lib/AwsMobileAnalyticsConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,22 @@ function initAwsMobileAnalytics () {

function recordDynamicCustomEvent (type) {
if (process.env.NODE_ENV !== 'production' || !ConfigManager.default.get().amaEnabled) return
mobileAnalyticsClient.recordEvent(type)
try {
mobileAnalyticsClient.recordEvent(type)
} catch (analyticsError) {
console.error(analyticsError)
}
}

function recordStaticCustomEvent () {
if (process.env.NODE_ENV !== 'production' || !ConfigManager.default.get().amaEnabled) return
mobileAnalyticsClient.recordEvent('UI_COLOR_THEME', {
uiColorTheme: ConfigManager.default.get().ui.theme
})
try {
mobileAnalyticsClient.recordEvent('UI_COLOR_THEME', {
uiColorTheme: ConfigManager.default.get().ui.theme
})
} catch (analyticsError) {
console.error(analyticsError)
}
}

module.exports = {
Expand Down