Skip to content

Conversation

@asmsuechan
Copy link
Contributor

@asmsuechan asmsuechan commented Oct 11, 2017

context

Pin to top feature is implemented.
6c5efcd90b5a0cf5b8d18a8ef1259eb5

before

This is a new feature so there's no before.

after

I'll write this later.

for tests

  • can add pin (snippet/markdown)
  • can remove pin (snippet/markdown)
  • not to be shown the context box on /home, /starred or /trash
  • not to be shown pinned icons on /home, /starred or /trash

@KLszTsu
Copy link
Contributor

KLszTsu commented Oct 11, 2017

Seeing the picture above, I think the pin icon should be brighter, and I think a white pin to use in dark themes is neccessary too.

Thanks.

@asmsuechan
Copy link
Contributor Author

I'm not in charge of style. That's why I ignore the ugly icon in spite of knowing that the style is not good. However, thank you for your comment.

@kazup01
Copy link
Member

kazup01 commented Oct 11, 2017

Great contribution @asmsuechan 🎉
I've been waiting for this feature. I will fix UI after merge it.

@kazup01
Copy link
Member

kazup01 commented Oct 28, 2017

This feature has just released at v0.8.16! Thanks @asmsuechan 🎉
#1027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants