Skip to content

Pin to top #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 13, 2017
Merged

Pin to top #956

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
fe8045c
Add pinn to top
asmsuechan Oct 13, 2017
8fd4deb
Add unpin
asmsuechan Oct 11, 2017
0ccb465
Remove pinnedNotes from Folder
asmsuechan Oct 11, 2017
5433abd
Remove console.log
asmsuechan Oct 11, 2017
6440395
Change to use strict equation
asmsuechan Oct 13, 2017
0e312ba
Change name Pinn to Pin
asmsuechan Oct 11, 2017
f337024
Add conditions to hide pin from /home, /starred or /trash
asmsuechan Oct 13, 2017
d915d19
Add comment for NoteItem
asmsuechan Oct 12, 2017
c33da0c
Fix some pointed by eslint
asmsuechan Oct 12, 2017
725c6a7
Resolve conflicts
asmsuechan Oct 13, 2017
2415fbf
Change to use const instead of let
asmsuechan Oct 13, 2017
3027cc8
Add handleNoteDelete
asmsuechan Oct 13, 2017
03fc453
Change method names
asmsuechan Oct 13, 2017
9bca133
Remove updateFolder because it's no longer used
asmsuechan Oct 13, 2017
f9b3284
Fix a condition
asmsuechan Oct 13, 2017
2003bea
Remove unnecessary lines
asmsuechan Oct 13, 2017
d274563
Change order for pinned notes on /home, /trashed, /searched or /starred
asmsuechan Oct 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix some pointed by eslint
  • Loading branch information
@asmsuechan
asmsuechan committed Oct 13, 2017
commit c33da0cf8e91ff9d349a143d396aa986267954fc
7 changes: 3 additions & 4 deletions browser/main/NoteList/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ class NoteList extends React.Component {
let storageKey = params.storageKey
let folderKey = params.folderKey
let storage = data.storageMap.get(storageKey)
if (location.pathname.match(/\/home|\/starred|\/trash/)){
if (location.pathname.match(/\/home|\/starred|\/trash/)) {
return unorderedNotes
}
if (storage === undefined) return []
Expand Down Expand Up @@ -441,14 +441,13 @@ class NoteList extends React.Component {
let note = this.notes[targetIndex]
const label = note.isPinned ? 'Remove pin' : 'Pin to Top'


let menu = new Menu()
menu.append(new MenuItem({
label: label,
click: (e) => this.handlePinToTop(e, uniqueKey)
}))

if (!location.pathname.match(/\/home|\/starred|\/trash/)){
if (!location.pathname.match(/\/home|\/starred|\/trash/)) {
menu.popup()
}
}
Expand Down Expand Up @@ -482,7 +481,7 @@ class NoteList extends React.Component {
return note != null && note.storage + '-' + note.key === uniqueKey
})
let note = this.notes[targetIndex]
note.isPinned = note.isPinned ? false : true
note.isPinned = !note.isPinned

dataApi
.updateNote(note.storage, note.key, note)
Expand Down