update #2
Merged
update #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix missing destructor call in NotePlayHandle
Add AppImage support
Fixes buffer noises when instruments don't write the whole buffer, such as bitinvader. Related: * #3884 (comment): #3884 (comment) * #3883 # #3383
Disable portaudio on Windows
* Replace MemoryManager implementation with rpmalloc
Fixes #3865
* Travis: Specify OSX image for Qt5 build
Note sorting algorithm rework
Let InstrumentSoundShaping::releaseFrames() ignore release frames for single-streamed instruments. And make it return 0 if m_instrumentTrack->instrument() is NULL.
* Fix Automation Point delete radius. At lower zoom deleting would miss automation points to delete and at higher zoom it would be too generous and remove neighbouring points. * Increase smallest Automation Point radius. For visibility. The smallest Automatin Point radius was tiny.
Regression from f9ab2de Don't follow quantization as you will have to move the cursor that length before any deletion is made.
* Fix crash when closing while previewing preset * Fix deadlock on previewing presets while playing arpeggio
Fix the noise burst described in #3842 by removing the second initialization of vca_a to 9 in the constructor of lb302Synth.
* swh - Dyson Compressor, fix NaN * swh - shaper_1187, division with 0 * Division with 0 in calf limiter
* Fix templates and recent files on KDE. Workaround for https://bugs.kde.org/show_bug.cgi?id=337491 , Call into KDE stuff to stop it adding accelerators. * Fix & in recent files. Escape & as && when building the recent file lists, and reverse that when getting the file name.
It's probably not the best "solution" but it should hopefully be one less category of crash-on-close on Mac. ASAN a.k.a Clang "AddressSanitizer".
Fix off-by-one visual glitch in automation editor and automation pattern view
Add libjack.so.0 fallback logic
…s in piano roll. (#3961) After shifting notes up/down, call rearrangeAllNotes() to sort notes and dataChanged() to update the pattern the Song Editor.
Default project when cancelling project loading If a user isn't aware that the loading of a project has been cancelled, it may be in an incomplete state. Saving such a project will overwrite the original file and result in data loss. This is solved by loading the default project on cancelling project loading. Add Mixer::clearNewPlayHandles() to prevent crash when cancelling loading of a single streamed instrument.
When you left click an existing value the automation point will only snap to the new value if it is higher. If it is lower the mouse click event will 'break'. Cleanup. Remove statement that will always evaluate as 'true'.
Change the default value of ignoreSurroundingPoints in AutomationPattern::putValue to true, which was false in #3352. Fixes automation filpping bug and some potential issues.
If a mixer channel is soloed when it's deleted the other channels are left in the state their in which is, for the most part, muted. Solve this by clearing mixer channels on delete.
Fix regression from b68dc57 Let the right mouse button delete the automation point like before and add the space above it too.
Closes #3925
Handle shrank automation patterns correctly
Fixes failing Travis-CI build
Build AppImage with Carla support * Disables HiDPI support in the AppImages * Ignores deprecated jack usage * Fix Carla compilation warnings * Detects carla prefix in AppRun
* Fix crash on closing * Fix audio rendering artifacts * Make LMMS work properly after rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.