-
-
Notifications
You must be signed in to change notification settings - Fork 432
chore: update the test runner #7404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Performance Report✔️ no performance regression detected Full benchmark results
|
81ab175 to
1d459f7
Compare
|
does your |
No there is some issue that is causing it to not be compatible. Was looking into it ChainSafe/benchmark#29. Will upgrade it very soon. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #7404 +/- ##
============================================
- Coverage 50.45% 50.17% -0.29%
============================================
Files 603 603
Lines 40661 40429 -232
Branches 2226 2225 -1
============================================
- Hits 20517 20284 -233
- Misses 20104 20105 +1
Partials 40 40 |
|
does this PR need vitest 3.x? can we maintain 2.x for now? |
01c80ca to
4fc6a6a
Compare
The Vitest 3 comes with a lot of changes, but for our interests are:
Vite 6 is considered more performant (specially for frontend stack). I was more interested in workspaces and started this PR because of it, but could not get that fit in our workflow. One issue running tests from individual package folder. So nothing critical for us, so can hold this PR merge or merge it. As you feel better. |
4fc6a6a to
11c3546
Compare
|
We were holding up this PR until |
|
🎉 This PR is included in v1.28.0 🎉 |
Motivation
Update vitest and browser engine.
Description
configsdirectorywebdriveriotoplaywrightwhich is more stable and recommended by Vitest.NOTE
Reverted the
playwrightupgrade. See the comments.lodestar/configs/vitest.config.base.browser.ts
Lines 41 to 43 in d2a7af0
Steps to test or reproduce
Run all tests