Skip to content

Conversation

@KoxyG
Copy link
Contributor

@KoxyG KoxyG commented Nov 15, 2025

Motivation

  • Replace the deprecated Holesky network with Hoodi, which is now Ethereum’s long-lived staking/infrastructure testnet (issue #8595).
  • Ensure Lodestar’s configs, CLI, tests, and documentation no longer reference Holesky so developers don’t run obsolete flows.

Description

  • Removed the Holesky network config and CLI entry points; Hoodi remains the only long-standing testnet option.
  • Updated all validator interop fixtures and tests to use the canonical Hoodi SpecJson, ensuring assertEqualParams validates against current parameters.
  • Replaced Holesky mentions in comments/docs/tests with Hoodi equivalents (Firehose, flare commands, prover, metrics, etc.) and left historical references where appropriate.
  • Cleaned up residual Holesky comments in beacon-node regen/importBlock to reference Hoodi incidents.

Steps to test or reproduce

Run the validator params test to ensure the new fixtures match Lodestar’s config:

yarn vitest run packages/validator/test/unit/utils/params.test.ts

AI Assistance Disclosure

  • PR content was developed using Cursor for code updates and explanations; I reviewed and verified all changes manually.

@KoxyG KoxyG requested a review from a team as a code owner November 15, 2025 10:56
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @KoxyG, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request completes the transition from the deprecated Holesky testnet to Hoodi across the Lodestar project. The changes ensure that the codebase, configurations, and testing infrastructure are fully aligned with Hoodi as the designated long-lived Ethereum staking testnet. This update streamlines development workflows by removing obsolete network references and standardizing on the current testnet environment.

Highlights

  • Holesky Deprecation: The deprecated Holesky network configurations and CLI entry points have been entirely removed from the codebase, ensuring that only current and supported testnets are referenced.
  • Hoodi Integration: All validator interop fixtures and tests have been updated to exclusively use the canonical Hoodi SpecJson, aligning the testing environment with Ethereum's new long-lived staking/infrastructure testnet.
  • Documentation and Comment Updates: Mentions of Holesky in comments, documentation, and various test files have been replaced with Hoodi equivalents, including references in Firehose, flare commands, prover, and metrics, with historical references preserved where appropriate.
  • Codebase Cleanup: Residual Holesky-specific comments within beacon-node's regen and importBlock modules have been cleaned up and updated to refer to Hoodi incidents, improving code clarity and relevance.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@KoxyG KoxyG changed the title Remove holesky configs and update tests to use hoodi fix: remove holesky configs and update tests to hoodi Nov 15, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively removes the deprecated Holesky network configuration and replaces it with Hoodi across the codebase. The changes are comprehensive, covering configurations, tests, documentation, and comments. The refactoring in packages/validator/test/unit/utils/interopConfigs.ts to generate test configurations from a single source of truth is a significant improvement for maintainability. I've found one minor inconsistency in a comment that could be addressed to improve clarity.

@philknows
Copy link
Member

I don't believe you understood the issue here. It wasn't to change every instance of the word holesky to hoodi, especially comments which were related specifically to the holesky testnet. You've changed some irrelevant content here such as the flare cli and you didn't rebase to our latest unstable where we've already removed some bun configs.

If you want to do this properly, please reach out to us on Discord to clarify for a redo. Sorry, but thanks for attemping. Closing PR.

@philknows philknows closed this Nov 15, 2025
nflaig pushed a commit that referenced this pull request Dec 8, 2025
**Motivation**

Replace deprecated Holesky network support with Hoodi testnet
configuration. Hoodi is a new Ethereum testnet that will serve as a
replacement testnet, and this change updates Lodestar to support the new
network configuration.

**Description**

This PR removes Holesky network configuration and replaces all
references with Hoodi testnet support. Changes include:

- Removed `packages/cli/src/networks/holesky.ts` network file
- Removed `packages/config/src/chainConfig/networks/holesky.ts` chain
config
- Updated all network references from "holesky" to "hoodi" across CLI,
config, and test files
- Added Hoodi network configuration with proper chain parameters,
genesis data, and bootnodes
- Updated default environment configuration
- Updated unit tests to reflect the network change


<!-- Link to issues: #8595
-->

Closes ##8615

**AI Assistance Disclosure**

- [ ] External Contributors: I have read the [contributor
guidelines](https://github.com/ChainSafe/lodestar/blob/unstable/CONTRIBUTING.md#ai-assistance-notice)
and disclosed my usage of AI below.

<!-- Insert any AI assistance disclosure here -->
-PR content was developed using Cursor for code updates and
explanations; I reviewed and verified all changes manually.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants