-
-
Notifications
You must be signed in to change notification settings - Fork 424
fix: remove holesky configs and update tests to hoodi #8615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @KoxyG, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request completes the transition from the deprecated Holesky testnet to Hoodi across the Lodestar project. The changes ensure that the codebase, configurations, and testing infrastructure are fully aligned with Hoodi as the designated long-lived Ethereum staking testnet. This update streamlines development workflows by removing obsolete network references and standardizing on the current testnet environment. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively removes the deprecated Holesky network configuration and replaces it with Hoodi across the codebase. The changes are comprehensive, covering configurations, tests, documentation, and comments. The refactoring in packages/validator/test/unit/utils/interopConfigs.ts to generate test configurations from a single source of truth is a significant improvement for maintainability. I've found one minor inconsistency in a comment that could be addressed to improve clarity.
|
I don't believe you understood the issue here. It wasn't to change every instance of the word holesky to hoodi, especially comments which were related specifically to the holesky testnet. You've changed some irrelevant content here such as the flare cli and you didn't rebase to our latest unstable where we've already removed some bun configs. If you want to do this properly, please reach out to us on Discord to clarify for a redo. Sorry, but thanks for attemping. Closing PR. |
**Motivation** Replace deprecated Holesky network support with Hoodi testnet configuration. Hoodi is a new Ethereum testnet that will serve as a replacement testnet, and this change updates Lodestar to support the new network configuration. **Description** This PR removes Holesky network configuration and replaces all references with Hoodi testnet support. Changes include: - Removed `packages/cli/src/networks/holesky.ts` network file - Removed `packages/config/src/chainConfig/networks/holesky.ts` chain config - Updated all network references from "holesky" to "hoodi" across CLI, config, and test files - Added Hoodi network configuration with proper chain parameters, genesis data, and bootnodes - Updated default environment configuration - Updated unit tests to reflect the network change <!-- Link to issues: #8595 --> Closes ##8615 **AI Assistance Disclosure** - [ ] External Contributors: I have read the [contributor guidelines](https://github.com/ChainSafe/lodestar/blob/unstable/CONTRIBUTING.md#ai-assistance-notice) and disclosed my usage of AI below. <!-- Insert any AI assistance disclosure here --> -PR content was developed using Cursor for code updates and explanations; I reviewed and verified all changes manually.
Motivation
Description
SpecJson, ensuringassertEqualParamsvalidates against current parameters.Steps to test or reproduce
Run the validator params test to ensure the new fixtures match Lodestar’s config:
yarn vitest run packages/validator/test/unit/utils/params.test.tsAI Assistance Disclosure