-
-
Notifications
You must be signed in to change notification settings - Fork 424
chore: remove holesky configs and update tests to hoodi #8622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @KoxyG, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a significant refactoring to deprecate and remove all traces of the Holesky testnet, replacing them with the Hoodi testnet. This change involves deleting specific network definition files, updating network lists and types, and modifying test cases and command examples to reflect the new Hoodi network. The overall purpose is to streamline the codebase by removing outdated network configurations and integrating the current testnet strategy. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes the 'holesky' testnet configuration and references from the codebase. The changes are mostly mechanical, involving file deletions and find-and-replace operations. The tests have been updated to use the 'hoodi' testnet where 'holesky' was previously used. The changes appear correct and consistent with the goal of removing the 'holesky' network. I've added one comment to improve the documentation in default.env.
|
Please also make sure you look at all the unit tests that still depend on holesky configs. Example: |
|
Converting to draft until ready for re-review |
|
Hi @philknows @nflaig I just made the changes |
nflaig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @KoxyG, looks pretty good
|
there are two more places we should update to hoodi
(also feel free to correct the example command) lodestar/packages/era/src/era/util.ts Line 13 in 1f2a3a4
|
|
i just made the changes, pls check @nflaig |
nflaig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @KoxyG
Thank you for your assistance. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #8622 +/- ##
============================================
- Coverage 52.05% 52.04% -0.01%
============================================
Files 848 848
Lines 65742 65735 -7
Branches 4808 4806 -2
============================================
- Hits 34219 34213 -6
+ Misses 31454 31453 -1
Partials 69 69 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in v1.38.0 🎉 |
Motivation
Replace deprecated Holesky network support with Hoodi testnet configuration. Hoodi is a new Ethereum testnet that will serve as a replacement testnet, and this change updates Lodestar to support the new network configuration.
Description
This PR removes Holesky network configuration and replaces all references with Hoodi testnet support. Changes include:
packages/cli/src/networks/holesky.tsnetwork filepackages/config/src/chainConfig/networks/holesky.tschain configCloses ##8615
AI Assistance Disclosure
-PR content was developed using Cursor for code updates and explanations; I reviewed and verified all changes manually.