Skip to content

fix(zh): correct subgraph terminology and fix Report/emDash translations (v0.8.36)#11981

Open
LifetimeVip wants to merge 3 commits intoComfy-Org:mainfrom
LifetimeVip:fix/zh-main-translation-corrections
Open

fix(zh): correct subgraph terminology and fix Report/emDash translations (v0.8.36)#11981
LifetimeVip wants to merge 3 commits intoComfy-Org:mainfrom
LifetimeVip:fix/zh-main-translation-corrections

Conversation

@LifetimeVip
Copy link
Copy Markdown
Contributor

@LifetimeVip LifetimeVip commented May 5, 2026

Summary

Corrects terminology and fixes mistranslations in the Simplified Chinese (zh) locale.

Changes

src/locales/zh/main.json:

Terminology fix: "Subgraph" → "子图"
The term "subgraph" was consistently mistranslated as "子工作流" (sub-workflow) across the UI. In ComfyUI, "subgraph" is a specific concept referring to a node group that acts as a reusable component, distinct from a workflow. The correct translation is "子图".

22 entries corrected across contextMenu, menuLabels, subgraphStore, and toastMessages sections.

Before After
子工作流 子图
子工作流名称 子图名称
子工作流蓝图 子图蓝图

Other fixes:

Key Before After Reason
queue.jobDetails.report 反馈 报告 "Report" here refers to submitting an error report, not general feedback
g.emDash - Restored proper em dash character

┆Issue is synchronized with this Notion page by Unito

@LifetimeVip LifetimeVip requested a review from a team May 5, 2026 20:18
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 5, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates the Simplified Chinese locale file to consistently use "子图" for subgraph-related UI strings, fixes an em dash character, adds nodeCategories.string = "字符串", and changes the queue job-details report label to "报错".

Changes

Chinese Locale Terminology & Text Updates

Layer / File(s) Summary
Context Menu Subgraph Labels
src/locales/zh/main.json
Context menu item labels for subgraph actions updated to use "子图" instead of "子工作流", covering add-to-library, convert, edit-widgets, and unpack operations.
Menu & Dialog Subgraph Labels
src/locales/zh/main.json
Main menu labels for subgraph operations updated to use "子图" terminology, including convert selection, edit subgraph widgets, exit subgraph, and unpack selected subgraph.
Subgraph Store & Messages
src/locales/zh/main.json
Subgraph store UI translations and toast/error messages switched to "子图" terminology, covering blueprint naming, deletion/overwrite confirmations, load failures, promotion/publishing labels, and conversion toasts.
Miscellaneous Text & Character Fixes
src/locales/zh/main.json
Em dash character replacement (g.emDash -> ), queue job-details report label changed to "报错", and added nodeCategories.string = "字符串".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

🐰 I nibbled through the lines tonight,
Swapped soft words to make them right,
子图跃入句与章,
破折稳当不再忙,
小改微欢心里亮 ✨


Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore (reviewers only)

❌ Failed checks (1 error)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❌ Error PR title contains bug-fix language ("fix"), no browser_tests/ files changed, and PR description lacks concrete explanation for why e2e regression test was not added. Add a Playwright regression test under browser_tests/ for the subgraph terminology and translation fixes, or add a concrete explanation in the PR description of why an e2e test is not practical.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main changes: correcting subgraph terminology and fixing translations for Report and emDash in the Chinese locale file.
Description check ✅ Passed The description provides a comprehensive summary with detailed information about terminology corrections, affected sections, and other fixes, following the template structure with summary and changes sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Adr Compliance For Entity/Litegraph Changes ✅ Passed Custom check does not apply. PR only modifies src/locales/zh/main.json (translation strings), not src/lib/litegraph/, src/ecs/, or graph entity files. No ADR 0003/0008 concerns present.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

🎨 Storybook: loading Building...

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

🎭 Playwright: ⏳ Running...

@LifetimeVip LifetimeVip changed the title fix(zh): correct subgraph terminology and fix Report/emDash translations fix(zh): correct subgraph terminology and fix Report/emDash translations (v0.8.36) May 5, 2026
@LifetimeVip LifetimeVip force-pushed the fix/zh-main-translation-corrections branch 5 times, most recently from cf0093d to 3fa6bfd Compare May 8, 2026 14:12
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/locales/zh/main.json`:
- Line 2497: The translation key queue.jobDetails.report uses "报告" while
adjacent keys (e.g., any keys for queue actions like queue.actions.* or
queue.jobDetails.* that currently read "反馈报错") are inconsistent; standardize
wording across the related keys by updating either queue.jobDetails.report to
"报告错误" or "提交报告" (or update the adjacent keys to match "报告"), and apply the same
phrase to all neighboring keys in the queue namespace (search for queue.actions,
queue.jobDetails, queue.* entries) so the UI uses a single, consistent label.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 41e1332d-e86a-4485-ad11-c9ac2d957c7d

📥 Commits

Reviewing files that changed from the base of the PR and between 8108967 and 3fa6bfd.

📒 Files selected for processing (1)
  • src/locales/zh/main.json

Comment thread src/locales/zh/main.json Outdated
Change from "报告" to "报错" for consistency with adjacent
keys like reportError ("反馈报错") and errorMessage ("报错信息").
@LifetimeVip LifetimeVip force-pushed the fix/zh-main-translation-corrections branch from 3fa6bfd to 8f18723 Compare May 8, 2026 16:53
@LifetimeVip
Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 8, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant