Enhanced custom icon support with tailwind #5159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Register svgs from custom icons folder - Update existing custom icons to remove padding - Swap component icons for classes in sidebar tabs - Update browse templates in menu to use custom icon
🎭 Playwright Test Results✅ All tests passed across all browsers! ⏰ Completed at: 08/21/2025, 08:38:18 PM UTC 📊 Test Reports by Browser
🎉 Your tests are passing across all browsers! |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 08/21/2025, 08:17:32 PM UTC 📊 Build Summary
🔗 Links🎉 Your Storybook is ready for review! |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
DrJKL
approved these changes
Aug 21, 2025
|
|
||
| import { comfyPageFixture as test } from '../fixtures/ComfyPage' | ||
|
|
||
| async function verifyCustomIconSvg(iconElement: Locator) { |
Contributor
There was a problem hiding this comment.
What do the errors for this look like in a failure state?
christian-byrne
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
@iconify/tailwindReview Focus
I have left in the support for component icons in sidebar tabs for extensions, if we don't think this is worth keeping i'm happy to remove it as the core no longer uses it.
Screenshots (if applicable)
New (left) vs old (right) icon size:
Browse templates uses custom icon:
┆Issue is synchronized with this Notion page by Unito