-
Notifications
You must be signed in to change notification settings - Fork 449
Enhanced custom icon support with tailwind #5159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| import { expect } from '@playwright/test' | ||
| import type { Locator } from '@playwright/test' | ||
|
|
||
| import { comfyPageFixture as test } from '../fixtures/ComfyPage' | ||
|
|
||
| async function verifyCustomIconSvg(iconElement: Locator) { | ||
| const svgVariable = await iconElement.evaluate((element) => { | ||
| const styles = getComputedStyle(element) | ||
| return styles.getPropertyValue('--svg') | ||
| }) | ||
|
|
||
| expect(svgVariable).toBeTruthy() | ||
| const dataUrlMatch = svgVariable.match( | ||
| /url\("data:image\/svg\+xml,([^"]+)"\)/ | ||
| ) | ||
| expect(dataUrlMatch).toBeTruthy() | ||
|
|
||
| const encodedSvg = dataUrlMatch![1] | ||
| const decodedSvg = decodeURIComponent(encodedSvg) | ||
|
|
||
| // Check for SVG header to confirm it's a valid SVG | ||
| expect(decodedSvg).toContain("<svg xmlns='http://www.w3.org/2000/svg'") | ||
| } | ||
|
|
||
| test.describe('Custom Icons', () => { | ||
| test.beforeEach(async ({ comfyPage }) => { | ||
| await comfyPage.setSetting('Comfy.UseNewMenu', 'Top') | ||
| }) | ||
|
|
||
| test('sidebar tab icons use custom SVGs', async ({ comfyPage }) => { | ||
| // Find the icon in the sidebar | ||
| const icon = comfyPage.page.locator( | ||
| '.icon-\\[comfy--ai-model\\].side-bar-button-icon' | ||
| ) | ||
| await expect(icon).toBeVisible() | ||
|
|
||
| // Verify the custom SVG content | ||
| await verifyCustomIconSvg(icon) | ||
| }) | ||
|
|
||
| test('Browse Templates menu item uses custom template icon', async ({ | ||
| comfyPage | ||
| }) => { | ||
| // Open the topbar menu | ||
| await comfyPage.menu.topbar.openTopbarMenu() | ||
| const menuItem = comfyPage.menu.topbar.getMenuItem('Browse Templates') | ||
|
|
||
| // Find the icon as a previous sibling of the menu item label | ||
| const templateIcon = menuItem | ||
| .locator('..') | ||
| .locator('.icon-\\[comfy--template\\]') | ||
| await expect(templateIcon).toBeVisible() | ||
|
|
||
| // Verify the custom SVG content | ||
| await verifyCustomIconSvg(templateIcon) | ||
| }) | ||
| }) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not TypeScript? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import { readFileSync, readdirSync } from 'fs' | ||
| import { join } from 'path' | ||
| import { dirname } from 'path' | ||
| import { fileURLToPath } from 'url' | ||
|
|
||
| const fileName = fileURLToPath(import.meta.url) | ||
| const dirName = dirname(fileName) | ||
| const customIconsPath = join(dirName, '..', 'src', 'assets', 'icons', 'custom') | ||
|
|
||
| // Create an Iconify collection for custom icons | ||
| export const iconCollection = { | ||
| prefix: 'comfy', | ||
| icons: {}, | ||
| width: 16, | ||
| height: 16 | ||
| } | ||
|
|
||
| // Read all SVG files from the custom icons directory | ||
| const files = readdirSync(customIconsPath) | ||
| files.forEach((file) => { | ||
| if (file.endsWith('.svg')) { | ||
| const name = file.replace('.svg', '') | ||
| const content = readFileSync(join(customIconsPath, file), 'utf-8') | ||
|
|
||
| iconCollection.icons[name] = { | ||
| body: content | ||
| } | ||
| } | ||
| }) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do the errors for this look like in a failure state?