ADR: Monorepo Conversion #5199
ADR: Monorepo Conversion #5199
Conversation
🎭 Playwright Test Results✅ All tests passed across all browsers! ⏰ Completed at: 08/25/2025, 08:25:38 PM UTC 📊 Test Reports by Browser
🎉 Your tests are passing across all browsers! |
|
|
||
| [PNPM](https://pnpm.io/) and [PNPM workspaces](https://pnpm.io/workspaces) | ||
|
|
||
| For monorepo management, I'd probably go with [Nx](https://nx.dev/), but I could be conviced otherwise. |
There was a problem hiding this comment.
I've had good experiences with NX. I've heard good things lately about Turborepo.
Anecdotally what I have heard from friends that have used both is that NX is a little harder to setup and maintain than Turborepo. But it's got way faster performance.
There was a problem hiding this comment.
Yeah, I've heard decent things about both of them. A few folks I tend to trust settled on Nx, but if it does end up being too painful, we can try Turbo.
|
|
||
| ### Negative | ||
|
|
||
| - Monorepos take some getting used to |
There was a problem hiding this comment.
The main trade off I've experienced:
- Working between packages gets much simpler. You don't have to navigate cross-repo dependency structures.
- The complexity just gets pushed to your build and CI process. If you don't keep those in good shape and reliable your productivity across all monorepo projects suffer.
| @@ -0,0 +1,50 @@ | |||
| # 2. Restructure ComfyUI_frontend as a monorepo | |||
There was a problem hiding this comment.
For the record, I'm for this. PNPM + NX. (And in hindsight should have just done a full code review 😂)
|
@arjansingh I'll merge this one and we can add more to the doc as we go. |
Do it. I'm onboard. |
Summary
Add initial Monorepo Proposal
Review Focus
Any obvious blockers that would make this not worth pursuing?
Any strong opinions about the tools getting started?
┆Issue is synchronized with this Notion page by Unito