ADR: PrimeVue Fork Decision #5230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds ADR-0003 documenting the decision to fork PrimeVue as a monorepo workspace package. Key rationale includes transform coordinate system conflicts and virtual canvas scroll interference that require component-level modifications.
dosubot
bot
added
the
size:M
🎭 Playwright Test Results✅ Tests completed successfully! ⏰ Completed at: 09/13/2025, 05:50:23 AM UTC 📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
christian-byrne
force-pushed
the
c_byrne/adr/primevue-fork
branch
from
1bfc976 to
fa13516
Compare
christian-byrne
commented
Aug 27, 2025
| 1. Add PrimeVue fork to `packages/@comfyui/primevue/` using git subtree | ||
| 2. Use `--squash` flag to avoid polluting contributor graph with upstream history | ||
| 3. Link via pnpm workspace: `"@comfyui/primevue": "workspace:*"` | ||
| 4. Mark vendored directory in `.gitattributes` with `linguist-vendored` |
Contributor
Author
There was a problem hiding this comment.
Actually, point 4 doesn't really make sense since we will be making adjustments to the vendored library over time.
christian-byrne
added
the
documentation
AustinMroz
previously approved these changes
Aug 27, 2025
Contributor
|
Discussed elsewhere: We might be able to use Nx import to do the setup. |
Contributor
Author
|
Worried that using |
- Change status from Proposed to Rejected - Document rationale: implementation complexity with dual monorepos, maintenance burden, alternative solutions available - Add specific code citations and repository links - Include alternative approach using shadcn/ui for selective replacement
- Rename 0003-fork-primevue-ui-library.md to 0004-fork-primevue-ui-library.md - Update ADR number in document header from 3 to 4 - Update README.md index to include both CRDT ADR-0003 and PrimeVue ADR-0004 - Maintain chronological order and avoid numbering conflicts
christian-byrne
commented
Sep 13, 2025
|
|
||
| ## Status | ||
|
|
||
| Rejected |
Contributor
Author
There was a problem hiding this comment.
Update to reflect final decision ("Rejected").
DrJKL
approved these changes
Sep 13, 2025
Myestery
pushed a commit
that referenced
this pull request
Sep 17, 2025
* ADR: Add PrimeVue fork decision record Adds ADR-0003 documenting the decision to fork PrimeVue as a monorepo workspace package. Key rationale includes transform coordinate system conflicts and virtual canvas scroll interference that require component-level modifications. * ADR: Reject PrimeVue fork decision - Change status from Proposed to Rejected - Document rationale: implementation complexity with dual monorepos, maintenance burden, alternative solutions available - Add specific code citations and repository links - Include alternative approach using shadcn/ui for selective replacement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds ADR-0003 documenting the architectural decision to fork PrimeVue as a monorepo workspace package. This ADR provides technical justification for why PrimeVue needs to be forked rather than used as an external dependency. Following from #5199.
Key Technical Issues Documented
getBoundingClientRect()+pageX/pageYcalculations that break in CSS transform coordinate spacesscrollIntoViewbehavior disrupts LiteGraph's semantic scroll coordinate systemReview Focus
The ADR follows the established format from previous ADRs and includes specific technical details with file references and line numbers for verification.
┆Issue is synchronized with this Notion page by Unito