Skip to content

fix: address reviewer feedback on cache optimization PR #5200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snomiao merged 2 commits into from
Aug 26, 2025
Merged

fix: address reviewer feedback on cache optimization PR #5200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4ed3e1
fix: remove duplicate cache entries and fix YAML formatting
christian-byrne Aug 25, 2025
6661426
fix: add cache-dependency-path for setup-node in test-ui workflow
christian-byrne Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/chromatic.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ jobs:
with:
path: |
.cache
node_modules/.cache
storybook-static
tsconfig.tsbuildinfo
key: storybook-cache-${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}-${{ hashFiles('src/**/*.{ts,vue,js}', '*.config.*', '.storybook/**/*') }}
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/dev-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,7 @@ jobs:
path: |
.cache
dist
node_modules/.cache
tsconfig.tsbuildinfo
.cache
tsconfig.tsbuildinfo
dist
key: dev-release-tools-cache-${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
dev-release-tools-cache-${{ runner.os }}-
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/i18n.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ jobs:
with:
path: |
ComfyUI_frontend/.cache
ComfyUI_frontend/node_modules/.cache
ComfyUI_frontend/.cache
key: i18n-tools-cache-${{ runner.os }}-${{ hashFiles('ComfyUI_frontend/package-lock.json') }}
restore-keys: |
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ jobs:
uses: actions/cache@v4
with:
path: |
node_modules/.cache
.cache
tsconfig.tsbuildinfo
key: release-tools-cache-${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
Expand Down Expand Up @@ -136,7 +135,6 @@ jobs:
uses: actions/cache@v4
with:
path: |
node_modules/.cache
.cache
tsconfig.tsbuildinfo
dist
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-ui.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ jobs:
with:
node-version: lts/*
cache: 'npm'
cache-dependency-path: 'ComfyUI_frontend/package-lock.json'

- name: Get current time
id: current-time
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/update-electron-types.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ jobs:
with:
path: |
.cache
node_modules/.cache
key: electron-types-tools-cache-${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
electron-types-tools-cache-${{ runner.os }}-
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/update-manager-types.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ jobs:
uses: actions/cache@v4
with:
path: |
node_modules/.cache
.cache
key: update-manager-tools-cache-${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/update-registry-types.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ jobs:
with:
path: |
.cache
node_modules/.cache
key: update-registry-tools-cache-${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
update-registry-tools-cache-${{ runner.os }}-
Expand Down