Skip to content

ADR: PrimeVue Fork Decision #5230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-byrne merged 3 commits into from
Sep 13, 2025
Merged

ADR: PrimeVue Fork Decision #5230

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa13516
ADR: Add PrimeVue fork decision record
christian-byrne Aug 27, 2025
5fa4042
ADR: Reject PrimeVue fork decision
christian-byrne Sep 13, 2025
a30e200
Resolve merge conflict: Rename PrimeVue ADR to 0004
christian-byrne Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Resolve merge conflict: Rename PrimeVue ADR to 0004 
- Rename 0003-fork-primevue-ui-library.md to 0004-fork-primevue-ui-library.md
- Update ADR number in document header from 3 to 4
- Update README.md index to include both CRDT ADR-0003 and PrimeVue ADR-0004
- Maintain chronological order and avoid numbering conflicts
  • Loading branch information
@christian-byrne
christian-byrne committed Sep 13, 2025
commit a30e20036dcce2431a5e46328484ca65e0d20603
2 changes: 1 addition & 1 deletion docs/adr/0003-fork-primevue-ui-library.md → docs/adr/0004-fork-primevue-ui-library.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# 3. Fork PrimeVue UI Library
# 4. Fork PrimeVue UI Library

Date: 2025-08-27

Expand Down
5 changes: 3 additions & 2 deletions docs/adr/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ An Architecture Decision Record captures an important architectural decision mad
| ADR | Title | Status | Date |
|-----|-------|--------|------|
| [0001](0001-merge-litegraph-into-frontend.md) | Merge LiteGraph.js into ComfyUI Frontend | Accepted | 2025-08-05 |
| [0002](0002-monorepo-conversion.md) | Restructure as a Monorepo | Proposed | 2025-08-25 |
| [0003](0003-fork-primevue-ui-library.md) | Fork PrimeVue UI Library | Proposed | 2025-08-27 |
| [0002](0002-monorepo-conversion.md) | Restructure as a Monorepo | Accepted | 2025-08-25 |
| [0003](0003-crdt-based-layout-system.md) | Centralized Layout Management with CRDT | Proposed | 2025-08-27 |
| [0004](0004-fork-primevue-ui-library.md) | Fork PrimeVue UI Library | Rejected | 2025-08-27 |

## Creating a New ADR

Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.