fix: feature flags and manager state handling

[viva-jinyi]

Summary

Fix ComfyUI Manager feature flag reactivity issues and improve manager state determination logic.

Changes

1. Replace reactive feature flags with non-reactive approach (72cb4d2)

• Changed managerUIState from computed property to getManagerUIState() function
• Ensures fresh computation on each call to avoid Vue reactivity timing issues
• Updates all consumers to use the new function-based approach

2. Add HelpCenter manager state handling and API version switching (0cc07bd)

• Fixed HelpCenter manager extension to check manager state
• Fixed 'Manager' command to respect manager state
• Added dynamic API prefix switching based on manager state (/api/ for legacy, /api/v2/ for new)

3. Simplify manager state determination and fix API timing issues (45de89e)

• Remove unnecessary extension check from manager state store
• Use only feature flags (client and server) for state determination
• Default to NEW_UI when server flags not loaded (safer default)
• Fix ImportFailInfoBulk to not send empty requests
• Resolves initial 404 errors on installed API calls

4. Correct manager state for non-v4 servers (f00eff2)

• Fix servers without v4 support returning DISABLED instead of LEGACY_UI
• Servers without v4 support should use legacy manager, not disable it
• Clarify condition for server v4 + client non-v4 case

Testing

• Unit tests updated and passing
• Tested with v4 enabled server
• Tested with v4 disabled server
• Tested manager UI state transitions
• Verified no 404 errors on initial load

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Fixes #5316

[github-actions]

🎭 Playwright Test Results

✅ All tests passed across all browsers!

⏰ Completed at: 09/06/2025, 12:19:06 PM UTC

📊 Test Reports by Browser

---

🎉 Your tests are passing across all browsers!

[christian-byrne]

Nice, thank you.

Some added clarification:

During Beta (previous)

• There was a single manager python server
• We needed to support using the old manager and new manager in a single frontend client session
• To do this, we created a new manager server API version

After Release (now)

• There are two manager python server packages. If the user is using legacy, the legacy server is initialized. If not, the new manager server is initialized.
• On the frontend
  • If legacy -> the legacy manager JS code is initialized. ComfyUI_frontend can simply disable all manager features
  • if disabled -> no manager JS code is initialized, no manager python server is initialized, ComfyUI_frontend can simply disable all of its manager features
  • else -> the legacy manager JS code is not initialized, ComfyUI_frontend only needs to support the new manager API version, doesn't need to worry about using interceptor or dynamically setting Axios client base URL

[viva-jinyi]

@christian-byrne

1) Centralized “Open Manager” logic

• Consolidated the repeated switch statements for Manager state (previously in 8+ files) into a single managerStateStore.openManager() function.
• All Manager entry points now call the centralized function:
  • useCoreCommands.ts: 6 commands
  • CommandMenubar.vue: Manage Extensions menu
  • HelpCenterMenuContent.vue: Manager button
  • LoadWorkflowWarning.vue: Open Manager button

2) New openManager() options

openManager(options?: {
  initialTab?: ManagerTab;           // Open a specific tab in NEW_UI
  legacyCommand?: string;            // Custom legacy command to run
  showToastOnLegacyError?: boolean;  // Show toast on legacy command failure
  isLegacyOnly?: boolean;            // Mark as legacy-only (error in NEW_UI)
});

3) Bug fixes

• In LEGACY_UI mode, when a legacy command fails, show an error toast instead of opening the new Manager.
• In NEW_UI mode, fixed an issue where legacy command errors were displayed as a numeric value.

🔍 Files changed

• src/stores/managerStateStore.ts — added openManager()
• src/composables/useCoreCommands.ts — refactored 6 Manager commands
• src/components/topbar/CommandMenubar.vue — simplified showManageExtensions()
• src/components/helpcenter/HelpCenterMenuContent.vue — simplified Manager action
• src/components/dialog/content/LoadWorkflowWarning.vue — simplified openManager() usage

✅ Verification

• TypeScript compile ✅
• ESLint pass ✅
• Unit tests ✅
• Manual checks for NEW_UI / LEGACY_UI / DISABLED modes ✅

[DrJKL]

I think if we're going to have non-reactive utilities like this, they should probably be separated from the stores. Maybe something in services/?

[viva-jinyi]

Refactoring: managerStateStore → useManagerState composable

Thank you for the feedback! @DrJKL is absolutely right about this.

Issue

• managerStateStore only provides non-reactive utility functions
• Doesn't align with Pinia store's purpose (reactive state management)
• Violates Pinia guideline: "If it's not reactive, it probably shouldn't be in a store"

Solution

Converted the Store to a Composable:

Changes:

• ✅ Moved src/stores/managerStateStore.ts → src/composables/useManagerState.ts
• ✅ Updated all import paths (8 files)
• ✅ Relocated and updated test files
• ✅ TypeScript type checking passes
• ✅ Unit tests passing

Benefits:

1. Pattern consistency: Other utility functions in the repo use composables
2. Clear separation of concerns: Stores for reactive state, Composables for business logic
3. Follows Pinia guidelines: Non-reactive code excluded from stores

Since Manager UI state doesn't change during runtime and is just a utility checking feature flags and command line args, a composable is the more appropriate pattern.

[christian-byrne]

This PR is really clean thanks for organizing this.

[christian-byrne]

LGTM!

[github-actions]

@viva-jinyi Backport to core/1.26 failed: Merge conflicts detected.

Please manually cherry-pick commit 2eb5c2ab911eada6e0b2d7109f57c32da44c982d to the core/1.26 branch.

Conflicting files

• src/components/topbar/CommandMenubar.vue
• src/stores/managerStateStore.ts