chore: unnecessary .value deleted & fetch name modified to refetch

src/components/dialog/content/ErrorDialogContent.vue

@@ -105,7 +105,7 @@ const showContactSupport = async () => {
 
 onMounted(async () => {
   if (!systemStatsStore.systemStats) {
-    await systemStatsStore.fetchSystemStats()
+    await systemStatsStore.refetchSystemStats()
   }
 
   try {

src/components/dialog/content/LoadWorkflowWarning.vue

@@ -107,12 +107,12 @@ const uniqueNodes = computed(() => {
 
 // Show manager buttons unless manager is disabled
 const showManagerButtons = computed(() => {
-  return managerState.shouldShowManagerButtons.value
+  return managerState.shouldShowManagerButtons
 })
 
 // Only show Install All button for NEW_UI (new manager with v4 support)
 const showInstallAllButton = computed(() => {
-  return managerState.shouldShowInstallButton.value
+  return managerState.shouldShowInstallButton
 })
 
 const openManager = async () => {

src/composables/nodePack/useWorkflowPacks.ts

@@ -61,7 +61,7 @@ export const useWorkflowPacks = (options: UseNodePacksOptions = {}) => {
     const nodeDef = nodeDefStore.nodeDefsByName[nodeName]
     if (nodeDef?.nodeSource.type === 'core') {
       if (!systemStatsStore.systemStats) {
-        await systemStatsStore.fetchSystemStats()
+        await systemStatsStore.refetchSystemStats()
       }
       return {
         id: CORE_NODES_PACK_NAME,

src/composables/useConflictDetection.ts

@@ -80,7 +80,7 @@ export function useConflictDetection() {
       const systemStatsStore = useSystemStatsStore()
       // Wait for systemStats to be initialized if not already
       if (!systemStatsStore.isInitialized) {
-        await systemStatsStore.fetchSystemStats()
+        await systemStatsStore.refetchSystemStats()
       }
 
       // Fetch version information from backend (with error resilience)

src/stores/releaseStore.ts

@@ -240,7 +240,7 @@ export const useReleaseStore = defineStore('release', () => {
     try {
       // Ensure system stats are loaded
       if (!systemStatsStore.systemStats) {
-        await systemStatsStore.fetchSystemStats()
+        await systemStatsStore.refetchSystemStats()
       }
 
       const fetchedReleases = await releaseService.getReleases({

src/stores/systemStatsStore.ts

@@ -20,7 +20,7 @@ export const useSystemStatsStore = defineStore('systemStats', () => {
     isLoading,
     error,
     isReady: isInitialized,
-    execute: fetchSystemStats
+    execute: refetchSystemStats
   } = useAsyncState<SystemStats | null>(
     fetchSystemStatsData,
     null, // initial value
@@ -65,7 +65,7 @@ export const useSystemStatsStore = defineStore('systemStats', () => {
     isLoading,
     error,
     isInitialized,
-    fetchSystemStats,
+    refetchSystemStats,
     getFormFactor
   }
 })

src/stores/versionCompatibilityStore.ts

@@ -103,7 +103,7 @@ export const useVersionCompatibilityStore = defineStore(
 
     async function checkVersionCompatibility() {
       if (!systemStatsStore.systemStats) {
-        await systemStatsStore.fetchSystemStats()
+        await systemStatsStore.refetchSystemStats()
       }
     }
 

tests-ui/tests/components/dialog/content/MissingCoreNodesMessage.spec.ts

@@ -33,14 +33,14 @@ const createMockNode = (type: string, version?: string): LGraphNode =>
 describe('MissingCoreNodesMessage', () => {
   const mockSystemStatsStore = {
     systemStats: null as { system?: { comfyui_version?: string } } | null,
-    fetchSystemStats: vi.fn()
+    refetchSystemStats: vi.fn()
   }
 
   beforeEach(() => {
     vi.clearAllMocks()
     // Reset the mock store state
     mockSystemStatsStore.systemStats = null
-    mockSystemStatsStore.fetchSystemStats = vi.fn()
+    mockSystemStatsStore.refetchSystemStats = vi.fn()
     // @ts-expect-error - Mocking the return value of useSystemStatsStore for testing.
     // The actual store has more properties, but we only need these for our tests.
     useSystemStatsStore.mockReturnValue(mockSystemStatsStore)

tests-ui/tests/composables/useConflictDetection.test.ts

@@ -96,7 +96,7 @@ describe.skip('useConflictDetection with Registry Store', () => {
   }
 
   const mockSystemStatsStore = {
-    fetchSystemStats: vi.fn(),
+    refetchSystemStats: vi.fn(),
     systemStats: {
       system: {
         comfyui_version: '0.3.41',
@@ -133,7 +133,7 @@ describe.skip('useConflictDetection with Registry Store', () => {
     } as any
 
     // Reset mock functions
-    mockSystemStatsStore.fetchSystemStats.mockResolvedValue(undefined)
+    mockSystemStatsStore.refetchSystemStats.mockResolvedValue(undefined)
     mockComfyManagerService.listInstalledPacks.mockReset()
     mockComfyManagerService.getImportFailInfo.mockReset()
     mockRegistryService.getPackByVersion.mockReset()
@@ -185,7 +185,7 @@ describe.skip('useConflictDetection with Registry Store', () => {
 
     it('should return fallback environment information when systemStatsStore fails', async () => {
       // Mock systemStatsStore failure
-      mockSystemStatsStore.fetchSystemStats.mockRejectedValue(
+      mockSystemStatsStore.refetchSystemStats.mockRejectedValue(
         new Error('Store failure')
       )
       mockSystemStatsStore.systemStats = null
@@ -754,7 +754,7 @@ describe.skip('useConflictDetection with Registry Store', () => {
   describe('error resilience with Registry Store', () => {
     it('should continue execution even when system environment detection fails', async () => {
       // Mock system stats store failure
-      mockSystemStatsStore.fetchSystemStats.mockRejectedValue(
+      mockSystemStatsStore.refetchSystemStats.mockRejectedValue(
         new Error('Store error')
       )
       mockSystemStatsStore.systemStats = null
@@ -851,7 +851,7 @@ describe.skip('useConflictDetection with Registry Store', () => {
 
     it('should handle complete system failure gracefully', async () => {
       // Mock all stores/services failing
-      mockSystemStatsStore.fetchSystemStats.mockRejectedValue(
+      mockSystemStatsStore.refetchSystemStats.mockRejectedValue(
         new Error('Critical error')
       )
       mockSystemStatsStore.systemStats = null

tests-ui/tests/composables/useManagerState.test.ts

@@ -296,7 +296,7 @@ describe('useManagerState', () => {
       } as any)
 
       const managerState = useManagerState()
-      expect(managerState.shouldShowInstallButton.value).toBe(true)
+      expect(managerState.shouldShowInstallButton).toBe(true)
     })
 
     it('shouldShowManagerButtons should return true when not DISABLED', () => {
@@ -313,7 +313,7 @@ describe('useManagerState', () => {
       } as any)
 
       const managerState = useManagerState()
-      expect(managerState.shouldShowManagerButtons.value).toBe(true)
+      expect(managerState.shouldShowManagerButtons).toBe(true)
     })
   })
 })

tests-ui/tests/store/releaseStore.test.ts

@@ -49,7 +49,7 @@ describe('useReleaseStore', () => {
           comfyui_version: '1.0.0'
         }
       },
-      fetchSystemStats: vi.fn(),
+      refetchSystemStats: vi.fn(),
       getFormFactor: vi.fn(() => 'git-windows')
     }
 
@@ -339,7 +339,7 @@ describe('useReleaseStore', () => {
 
       await store.initialize()
 
-      expect(mockSystemStatsStore.fetchSystemStats).toHaveBeenCalled()
+      expect(mockSystemStatsStore.refetchSystemStats).toHaveBeenCalled()
     })
 
     it('should not set loading state when notifications disabled', async () => {
@@ -406,7 +406,7 @@ describe('useReleaseStore', () => {
 
       await store.fetchReleases()
 
-      expect(mockSystemStatsStore.fetchSystemStats).toHaveBeenCalled()
+      expect(mockSystemStatsStore.refetchSystemStats).toHaveBeenCalled()
       expect(mockReleaseService.getReleases).toHaveBeenCalled()
     })
   })
@@ -530,7 +530,7 @@ describe('useReleaseStore', () => {
       await store.initialize()
 
       // Should not fetch system stats when notifications disabled
-      expect(mockSystemStatsStore.fetchSystemStats).not.toHaveBeenCalled()
+      expect(mockSystemStatsStore.refetchSystemStats).not.toHaveBeenCalled()
     })
 
     it('should handle concurrent fetchReleases calls', async () => {

tests-ui/tests/store/systemStatsStore.test.ts

@@ -39,7 +39,7 @@ describe('useSystemStatsStore', () => {
     expect(store.isInitialized).toBe(true) // Should be initialized after fetch
   })
 
-  describe('fetchSystemStats', () => {
+  describe('refetchSystemStats', () => {
     it('should fetch system stats successfully', async () => {
       const mockStats = {
         system: {
@@ -58,7 +58,7 @@ describe('useSystemStatsStore', () => {
 
       vi.mocked(api.getSystemStats).mockResolvedValue(mockStats)
 
-      await store.fetchSystemStats()
+      await store.refetchSystemStats()
 
       expect(store.systemStats).toEqual(mockStats)
       expect(store.isLoading).toBe(false)
@@ -71,7 +71,7 @@ describe('useSystemStatsStore', () => {
       const error = new Error('API Error')
       vi.mocked(api.getSystemStats).mockRejectedValue(error)
 
-      await store.fetchSystemStats()
+      await store.refetchSystemStats()
 
       expect(store.systemStats).toBeNull() // Initial value stays null on error
       expect(store.isLoading).toBe(false)
@@ -81,7 +81,7 @@ describe('useSystemStatsStore', () => {
     it('should handle non-Error objects', async () => {
       vi.mocked(api.getSystemStats).mockRejectedValue('String error')
 
-      await store.fetchSystemStats()
+      await store.refetchSystemStats()
 
       expect(store.error).toBe('String error') // useAsyncState stores the actual error
     })
@@ -93,7 +93,7 @@ describe('useSystemStatsStore', () => {
       })
       vi.mocked(api.getSystemStats).mockReturnValue(promise)
 
-      const fetchPromise = store.fetchSystemStats()
+      const fetchPromise = store.refetchSystemStats()
       expect(store.isLoading).toBe(true)
 
       resolvePromise({})
@@ -120,7 +120,7 @@ describe('useSystemStatsStore', () => {
 
       vi.mocked(api.getSystemStats).mockResolvedValue(updatedStats)
 
-      await store.fetchSystemStats()
+      await store.refetchSystemStats()
 
       expect(store.systemStats).toEqual(updatedStats)
       expect(store.isLoading).toBe(false)

tests-ui/tests/store/versionCompatibilityStore.test.ts

@@ -31,7 +31,7 @@ describe('useVersionCompatibilityStore', () => {
 
     mockSystemStatsStore = {
       systemStats: null,
-      fetchSystemStats: vi.fn()
+      refetchSystemStats: vi.fn()
     }
 
     vi.mocked(useSystemStatsStore).mockReturnValue(mockSystemStatsStore)
@@ -302,7 +302,7 @@ describe('useVersionCompatibilityStore', () => {
 
       await store.initialize()
 
-      expect(mockSystemStatsStore.fetchSystemStats).toHaveBeenCalled()
+      expect(mockSystemStatsStore.refetchSystemStats).toHaveBeenCalled()
     })
 
     it('should not fetch system stats if already available', async () => {
@@ -315,7 +315,7 @@ describe('useVersionCompatibilityStore', () => {
 
       await store.initialize()
 
-      expect(mockSystemStatsStore.fetchSystemStats).not.toHaveBeenCalled()
+      expect(mockSystemStatsStore.refetchSystemStats).not.toHaveBeenCalled()
     })
   })
 })