Skip to content

Conversation

@Myestery
Copy link
Collaborator

@Myestery Myestery commented Sep 3, 2025

This pull request updates the UI test workflow configuration to simplify Playwright browser setup and improve test reliability. The most notable changes are the removal of the Playwright browser caching steps and the adjustment of test timeouts and artifact naming.

Workflow simplification and reliability:

  • Removed the Playwright browser caching steps from both the setup and test jobs to ensure browsers are always freshly installed, reducing potential cache-related issues. [1] [2]
  • Set a timeout of 15 minutes for each Playwright test shard to prevent jobs from hanging indefinitely and to better manage CI resources.

Artifact management:

  • Renamed the uploaded Playwright HTML report artifact from playwright-report-chromium-merged to playwright-report-chromium for consistency with the rest of the workflow.

@github-actions
Copy link

github-actions bot commented Sep 3, 2025

🎭 Playwright Test Results

All tests passed across all browsers!

⏰ Completed at: 09/03/2025, 10:16:11 PM UTC

📊 Test Reports by Browser


🎉 Your tests are passing across all browsers!

@Myestery
Copy link
Collaborator Author

Myestery commented Sep 3, 2025

Thanks to @arjansingh and @DrJKL for the reviews on #5311

@Myestery Myestery marked this pull request as ready for review September 3, 2025 22:17
@Myestery Myestery requested a review from a team as a code owner September 3, 2025 22:17
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 3, 2025
Copy link
Contributor

@arjansingh arjansingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

retention-days: 1

playwright-tests:
# Ideally, each shard runs test in 6 minutes, but allow up to 15 minutes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Myestery Myestery merged commit 3c247e5 into main Sep 3, 2025
22 checks passed
@Myestery Myestery deleted the playwright-shard-cache branch September 3, 2025 22:22
arjansingh pushed a commit that referenced this pull request Sep 3, 2025
* [refactor] Remove caching of Playwright browsers from CI workflow

* restore upload artifact path

* [fix] Adjust timeout for playwright tests to allow up to 15 minutes

* [fix] Update artifact name for Playwright report to match standard naming convention
@benceruleanlu benceruleanlu mentioned this pull request Sep 4, 2025
snomiao pushed a commit that referenced this pull request Sep 12, 2025
* [refactor] Remove caching of Playwright browsers from CI workflow

* restore upload artifact path

* [fix] Adjust timeout for playwright tests to allow up to 15 minutes

* [fix] Update artifact name for Playwright report to match standard naming convention
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants