Skip to content

Remove caching of Playwright browsers from CI workflow #5325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Myestery merged 5 commits into from
Sep 3, 2025
Merged

Remove caching of Playwright browsers from CI workflow #5325

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d753ae2
[refactor] Remove caching of Playwright browsers from CI workflow
Myestery Sep 3, 2025
a846776
restore upload artifact path
Myestery Sep 3, 2025
48baddc
Merge branch 'main' into playwright-shard-cache
Myestery Sep 3, 2025
cab0b03
[fix] Adjust timeout for playwright tests to allow up to 15 minutes
Myestery Sep 3, 2025
8444a8d
[fix] Update artifact name for Playwright report to match standard na…
Myestery Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 3 additions & 19 deletions .github/workflows/test-ui.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,15 +122,6 @@ jobs:
wait-for-it --service 127.0.0.1:8188 -t 600
working-directory: ComfyUI

- name: Cache Playwright browsers
uses: actions/cache@v4
with:
path: ~/.cache/ms-playwright
key: playwright-browsers-${{ runner.os }}-${{ hashFiles('ComfyUI_frontend/pnpm-lock.yaml') }}-chromium
restore-keys: |
playwright-browsers-${{ runner.os }}-${{ hashFiles('ComfyUI_frontend/pnpm-lock.yaml') }}-
playwright-browsers-${{ runner.os }}-

- name: Install Playwright Browsers
run: npx playwright install chromium --with-deps
working-directory: ComfyUI_frontend
Expand All @@ -150,6 +141,8 @@ jobs:
retention-days: 1

playwright-tests:
# Ideally, each shard runs test in 6 minutes, but allow up to 15 minutes
Copy link
Contributor

@arjansingh arjansingh Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

timeout-minutes: 15
needs: setup
runs-on: ubuntu-latest
permissions:
Expand Down Expand Up @@ -195,15 +188,6 @@ jobs:
wait-for-it --service 127.0.0.1:8188 -t 600
working-directory: ComfyUI

- name: Cache Playwright browsers
uses: actions/cache@v4
with:
path: ~/.cache/ms-playwright
key: playwright-browsers-${{ runner.os }}-${{ hashFiles('ComfyUI_frontend/pnpm-lock.yaml') }}-${{ matrix.browser }}
restore-keys: |
playwright-browsers-${{ runner.os }}-${{ hashFiles('ComfyUI_frontend/pnpm-lock.yaml') }}-
playwright-browsers-${{ runner.os }}-

- name: Install Playwright Browsers
run: npx playwright install chromium --with-deps
working-directory: ComfyUI_frontend
Expand Down Expand Up @@ -262,6 +246,6 @@ jobs:
- name: Upload HTML report
uses: actions/upload-artifact@v4
with:
name: playwright-report-chromium-merged
name: playwright-report-chromium
path: ComfyUI_frontend/playwright-report/
retention-days: 30