Skip to content

allow Vue nodes to be resized from all 4 corners #6187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-byrne merged 12 commits into from
Oct 23, 2025
Merged

allow Vue nodes to be resized from all 4 corners #6187

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e983786
resize from all 4 corners
christian-byrne Oct 21, 2025
cfe0676
simplify tests
christian-byrne Oct 21, 2025
78b3ef4
[refactor] use Math.max instead of clamp for min size constraints - a…
christian-byrne Oct 22, 2025
4e1168f
[refactor] extract validated resize state to local variables - addres…
christian-byrne Oct 23, 2025
1a6171e
[refactor] extract CornerResizeHandle type and annotate array - addre…
christian-byrne Oct 23, 2025
b3fcf8a
[refactor] rename moveTo to moveNodeTo in useNodeLayout - addresses r…
christian-byrne Oct 23, 2025
68255c9
[style] use Tailwind group pattern for resize handle visibility - add…
christian-byrne Oct 23, 2025
fc4a43d
[refactor] rename factor variables to multiplier for clarity - addres…
christian-byrne Oct 23, 2025
b54e919
[a11y] add aria-label and role to resize handles - addresses review f…
christian-byrne Oct 23, 2025
27222a0
[test] add edge case tests for resize math - addresses review feedback
christian-byrne Oct 23, 2025
feda4d9
[fix] keep resize handles invisible - only show cursor change
christian-byrne Oct 23, 2025
320ede5
[automated] Apply ESLint and Prettier fixes
actions-user Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[refactor] rename moveTo to moveNodeTo in useNodeLayout - addresses r… 
…eview feedback

Co-authored-by: DrJKL <[email protected]>
  • Loading branch information
@christian-byrne @DrJKL
christian-byrne and DrJKL committed Oct 23, 2025
commit b3fcf8adddc08dee97a9d854884ad1b20a8c2fb1
7 changes: 1 addition & 6 deletions src/renderer/extensions/vueNodes/components/LGraphNode.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,12 +247,7 @@ onErrorCaptured((error) => {
return false // Prevent error propagation
})

const {
position,
size,
zIndex,
moveTo: moveNodeTo
} = useNodeLayout(() => nodeData.id)
const { position, size, zIndex, moveNodeTo } = useNodeLayout(() => nodeData.id)
const { pointerHandlers, isDragging, dragStyle } = useNodePointerInteractions(
() => nodeData,
handleNodeSelect
Expand Down
4 changes: 2 additions & 2 deletions src/renderer/extensions/vueNodes/layout/useNodeLayout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ export function useNodeLayout(nodeIdMaybe: MaybeRefOrGetter<string>) {
/**
* Update node position directly (without drag)
*/
function moveTo(position: Point) {
function moveNodeTo(position: Point) {
mutations.setSource(LayoutSource.Vue)
mutations.moveNode(nodeId, position)
}
Expand All @@ -269,7 +269,7 @@ export function useNodeLayout(nodeIdMaybe: MaybeRefOrGetter<string>) {
isDragging,

// Mutations
moveTo,
moveNodeTo,

// Drag handlers
startDrag,
Expand Down