Skip to content

allow Vue nodes to be resized from all 4 corners #6187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-byrne merged 12 commits into from
Oct 23, 2025
Merged

allow Vue nodes to be resized from all 4 corners #6187

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e983786
resize from all 4 corners
christian-byrne Oct 21, 2025
cfe0676
simplify tests
christian-byrne Oct 21, 2025
78b3ef4
[refactor] use Math.max instead of clamp for min size constraints - a…
christian-byrne Oct 22, 2025
4e1168f
[refactor] extract validated resize state to local variables - addres…
christian-byrne Oct 23, 2025
1a6171e
[refactor] extract CornerResizeHandle type and annotate array - addre…
christian-byrne Oct 23, 2025
b3fcf8a
[refactor] rename moveTo to moveNodeTo in useNodeLayout - addresses r…
christian-byrne Oct 23, 2025
68255c9
[style] use Tailwind group pattern for resize handle visibility - add…
christian-byrne Oct 23, 2025
fc4a43d
[refactor] rename factor variables to multiplier for clarity - addres…
christian-byrne Oct 23, 2025
b54e919
[a11y] add aria-label and role to resize handles - addresses review f…
christian-byrne Oct 23, 2025
27222a0
[test] add edge case tests for resize math - addresses review feedback
christian-byrne Oct 23, 2025
feda4d9
[fix] keep resize handles invisible - only show cursor change
christian-byrne Oct 23, 2025
320ede5
[automated] Apply ESLint and Prettier fixes
actions-user Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
simplify tests
  • Loading branch information
@christian-byrne @DrJKL
christian-byrne authored and DrJKL committed Oct 22, 2025
commit cfe067631c90875ae579cbbc4e8dae2ef5e422ba
28 changes: 27 additions & 1 deletion src/renderer/extensions/vueNodes/components/LGraphNode.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,6 @@ import {
} from '@/utils/graphTraversalUtil'
import { cn } from '@/utils/tailwindUtil'

import { cornerResizeHandles } from '../interactions/resize/resizeHandlePresets'
import type { ResizeHandleDirection } from '../interactions/resize/resizeMath'
import { useNodeResize } from '../interactions/resize/useNodeResize'
import { calculateIntrinsicSize } from '../utils/calculateIntrinsicSize'
Expand Down Expand Up @@ -295,6 +294,33 @@ const baseResizeHandleClasses =
'absolute h-3 w-3 opacity-0 pointer-events-auto focus-visible:outline focus-visible:outline-2 focus-visible:outline-white/40'
Copy link

@claude claude bot Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[performance] low Priority

Issue: Resize handles always rendered but invisible by default
Context: All 4 handles are rendered in DOM with opacity-0, which creates unnecessary DOM nodes
Suggestion: Consider using v-show or CSS-only hover reveal to avoid DOM overhead when not needed

Copy link
Contributor

@DrJKL DrJKL Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tailwindcss.com/docs/hover-focus-and-other-states#styling-based-on-parent-state

Copy link
Contributor Author

@christian-byrne christian-byrne Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented in 68255c9 (removed in feda4d9 to keep handles invisible)

Copy link
Contributor Author

@christian-byrne christian-byrne Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed (handles remain invisible with cursor-only indication)

const POSITION_EPSILON = 0.01
Copy link

@claude claude bot Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[quality] low Priority

Issue: Magic number POSITION_EPSILON without explanation
Context: Value 0.01 is used to check position changes but lacks documentation about why this threshold was chosen
Suggestion: Add comment explaining the epsilon value rationale or extract to a named constant with documentation

Copy link
Contributor Author

@christian-byrne christian-byrne Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping - unclear rationale for the threshold


const cornerResizeHandles = [
{
id: 'se',
direction: { horizontal: 'right', vertical: 'bottom' } as const,
classes: 'right-0 bottom-0 cursor-se-resize'
},
{
id: 'ne',
direction: { horizontal: 'right', vertical: 'top' } as const,
classes: 'right-0 top-0 cursor-ne-resize'
},
{
id: 'sw',
direction: { horizontal: 'left', vertical: 'bottom' } as const,
classes: 'left-0 bottom-0 cursor-sw-resize'
},
{
id: 'nw',
direction: { horizontal: 'left', vertical: 'top' } as const,
classes: 'left-0 top-0 cursor-nw-resize'
}
] satisfies Array<{
id: string
direction: ResizeHandleDirection
classes: string
}>

const { startResize } = useNodeResize(
(result, element) => {
if (isCollapsed.value) return
Expand Down
31 changes: 0 additions & 31 deletions src/renderer/extensions/vueNodes/interactions/resize/resizeHandlePresets.ts
View file
Open in desktop

This file was deleted.