Skip to content

fix: Refresh model dropdowns after upload #7232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DrJKL merged 4 commits into from
Dec 8, 2025
Merged

fix: Refresh model dropdowns after upload #7232

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c45ffef
fix: Refresh model dropdowns after upload
luke-mino-altherr Dec 8, 2025
b45f179
refactor: Use Pinia store instead of window events for model refresh
luke-mino-altherr Dec 8, 2025
970e87c
refactor: Move cache refresh logic to caller
luke-mino-altherr Dec 8, 2025
8598741
Merge branch 'main' into fix/model-dropdown-refresh-after-upload
DrJKL Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/platform/assets/composables/useUploadModelWizard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,14 @@ export function useUploadModelWizard(modelTypes: Ref<ModelTypeOption[]>) {

uploadStatus.value = 'success'
currentStep.value = 3

// Emit event for store to invalidate caches
window.dispatchEvent(
new CustomEvent('model-upload-success', {
detail: { modelType: selectedModelType.value }
})
)

return true
} catch (error) {
console.error('Failed to upload asset:', error)
Expand Down
17 changes: 17 additions & 0 deletions src/renderer/extensions/vueNodes/widgets/composables/useAssetWidgetData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { computed, toValue, watch } from 'vue'
import type { MaybeRefOrGetter } from 'vue'
import { useEventListener } from '@vueuse/core'

import { isCloud } from '@/platform/distribution/types'
import type { AssetItem } from '@/platform/assets/schemas/assetSchema'
Expand Down Expand Up @@ -80,6 +81,22 @@ export function useAssetWidgetData(
{ immediate: true }
)

// Listen for model upload events and refetch data
if (typeof window !== 'undefined') {
useEventListener(window, 'model-upload-success', async (event: Event) => {
const currentNodeType = toValue(nodeType)
if (!currentNodeType) return

const customEvent = event as CustomEvent<{ modelType: string }>
const uploadedModelType = customEvent.detail?.modelType

// Only refetch if the uploaded model type matches this widget's category
if (uploadedModelType && uploadedModelType === category.value) {
await assetsStore.updateModelsForNodeType(currentNodeType)
}
})
}
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Add error handling for async store update.

The event listener correctly filters by category to minimize unnecessary API calls. However, the call to assetsStore.updateModelsForNodeType is not wrapped in error handling.

Apply this diff to add error handling:

     // Listen for model upload events and refetch data
     if (typeof window !== 'undefined') {
       useEventListener(window, 'model-upload-success', async (event: Event) => {
         const currentNodeType = toValue(nodeType)
         if (!currentNodeType) return
 
         const customEvent = event as CustomEvent<{ modelType: string }>
         const uploadedModelType = customEvent.detail?.modelType
 
         // Only refetch if the uploaded model type matches this widget's category
         if (uploadedModelType && uploadedModelType === category.value) {
-          await assetsStore.updateModelsForNodeType(currentNodeType)
+          try {
+            await assetsStore.updateModelsForNodeType(currentNodeType)
+          } catch (error) {
+            console.error('Failed to refresh models after upload:', error)
+          }
         }
       })
     }

As per coding guidelines: "Implement proper error handling"

🤖 Prompt for AI Agents 
In src/renderer/extensions/vueNodes/widgets/composables/useAssetWidgetData.ts
around lines 84 to 98, the async call to assetsStore.updateModelsForNodeType
inside the model-upload-success event listener lacks error handling; wrap the
await call in a try/catch, and in the catch block log the error with contextual
information (including currentNodeType and category.value) so failures are
visible and safe to ignore for the UI; ensure the listener remains async and
does not rethrow the error.


return {
category,
assets,
Expand Down
Loading